Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Crowdin configuration - WPB-15715 #2429

Merged
merged 3 commits into from
Jan 27, 2025
Merged

fix: Crowdin configuration - WPB-15715 #2429

merged 3 commits into from
Jan 27, 2025

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Jan 27, 2025 •
edited by github-actions bot
Loading

BugWPB-15715 [iOS] Fix crowdin config

Issue

This PR adds WireIndividualToTeamMigrationUI/Resources/Accessibility.xcstrings and WireIndividualToTeamMigrationUI/Resources/Localizable.xcstrings to crowdin.yml.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian requested a review from netbe January 27, 2025 10:18
@caldrian caldrian requested a review from KaterinaWire January 27, 2025 10:18
caldrian
caldrian commented Jan 27, 2025
View reviewed changes
crowdin.yml Show resolved Hide resolved
caldrian
caldrian commented Jan 27, 2025
View reviewed changes
crowdin.yml Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited
Loading

Test Results

    1 files      2 suites   2m 11s ⏱️
1 789 tests 1 763 ✅ 26 💤 0 ❌
1 799 runs  1 773 ✅ 26 💤 0 ❌

Results for commit 325c2bb.

♻️ This comment has been updated with latest results.

@caldrian caldrian enabled auto-merge (squash) January 27, 2025 10:25
@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/crowdin-configuration-WPB-10347
Commit report: afb856e
Test service: wire-ios-mono

✅ 0 Failed, 1685 Passed, 26 Skipped, 2m 10.91s Total Time

@caldrian caldrian changed the title fix: Crowdin configuration - WPB-10347 fix: Crowdin configuration - WPB-15715 Jan 27, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 27, 2025
@caldrian caldrian merged commit 4509c18 into release/cycle-3.115 Jan 27, 2025
12 of 13 checks passed
@caldrian caldrian deleted the fix/crowdin-configuration-WPB-10347 branch January 27, 2025 10:58
@github-actions github-actions bot mentioned this pull request Jan 27, 2025
Merged
6 tasks
caldrian added a commit that referenced this pull request Jan 27, 2025
@caldrian
fix: Crowdin configuration - WPB-10347 (#2429)
9fd23e3
@github-actions github-actions bot mentioned this pull request Jan 27, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jullianm jullianm jullianm approved these changes

@netbe netbe netbe approved these changes

@KaterinaWire KaterinaWire Awaiting requested review from KaterinaWire

Assignees

@caldrian caldrian

Labels
echoes/initiative: personal-users-to-team-users... echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caldrian @netbe @jullianm