Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip notification when away or busy - WPB-8946 #2438

Merged

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Jan 27, 2025

BugWPB-8946 [iOS] I should not get notifications from new groups when my status is set to Away

Issue

The notification extension compares the availability status of the self user with the settings of any conversation's incoming notification. Based on that it is decided if a local notification is scheduled or not.

In the case of a new conversation event, where the conversation is not yet available in the local db, the check doesn't consider the user's availability and always shows the notification.

This PR handles this edge case and decides based on the availability status.

Testing

  • Quit the app
  • From another user create a conversation
  • Depending on the availability settings a notification is shown (for .none, .available) or not (for .busy, .away).

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jan 27, 2025
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Test Results

1 192 tests   1 192 ✅  1m 36s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit b36ee96.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 27, 2025

Datadog Report

Branch report: fix/skip-notification-when-away-WPB-8946
Commit report: 012cacb
Test service: wire-ios-mono

✅ 0 Failed, 1093 Passed, 0 Skipped, 1m 36.82s Total Time

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@caldrian caldrian enabled auto-merge (squash) January 28, 2025 12:39
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛

@caldrian caldrian merged commit f7315f6 into release/cycle-3.116 Jan 28, 2025
8 of 9 checks passed
@caldrian caldrian deleted the fix/skip-notification-when-away-WPB-8946 branch January 28, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants