-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip notification when away or busy - WPB-8946 #2438
fix: skip notification when away or busy - WPB-8946 #2438
Conversation
...Notifications/Push Notifications/Notification Types/Content/ZMLocalNotification+Events.swift
Show resolved
Hide resolved
Test Results1 192 tests 1 192 ✅ 1m 36s ⏱️ Results for commit b36ee96. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 1093 Passed, 0 Skipped, 1m 36.82s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐛
Issue
The notification extension compares the availability status of the self user with the settings of any conversation's incoming notification. Based on that it is decided if a local notification is scheduled or not.
In the case of a new conversation event, where the conversation is not yet available in the local db, the check doesn't consider the user's availability and always shows the notification.
This PR handles this edge case and decides based on the availability status.
Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: