Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ServerTrustValidatorTests - WPB-15760 #2440

Merged
merged 2 commits into from
Jan 28, 2025
Merged

fix: ServerTrustValidatorTests - WPB-15760 #2440

merged 2 commits into from
Jan 28, 2025

Conversation

samwyndham
Copy link
Contributor

@samwyndham samwyndham commented Jan 28, 2025 •
edited by github-actions bot
Loading

BugWPB-15760 [iOS] Fix `ServerTrustValidatorTests`

Issue

This PR fixes ServerTrustValidatorTests.testValidate_whenNoMatchingPublicKey which is failing because the certificate data it is using (of google.com) has become outdated. To fix this PR:

  • Updates the certificate data
  • Adds comments on how to update this data in the future.

Testing

Run automated tests

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@github-actions GitHub Actions
Copy link
Contributor

Test Results

204 tests   204 ✅  1s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 99135d7.

@samwyndham samwyndham enabled auto-merge (squash) January 28, 2025 13:54
@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/server-trust-validator-tests
Commit report: bc9f8bf
Test service: wire-ios-mono

✅ 0 Failed, 204 Passed, 0 Skipped, 1.4s Total Time

netbe
netbe approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thks for the doc!

@samwyndham samwyndham merged commit 02da120 into release/cycle-3.116 Jan 28, 2025
13 of 14 checks passed
@samwyndham samwyndham deleted the fix/server-trust-validator-tests branch January 28, 2025 14:05
zenkins pushed a commit that referenced this pull request Jan 28, 2025
@samwyndham @github-actions
fix: ServerTrustValidatorTests - WPB-15760 (#2440)
d7da9e1
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@El-Fitz El-Fitz El-Fitz approved these changes

@netbe netbe netbe approved these changes

Assignees

@samwyndham samwyndham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samwyndham @netbe @El-Fitz