fix: Not able to swipe - WPB-17839 #3082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results1 799 tests 1 773 ✅ 2m 3s ⏱️ Results for commit cbbca30. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 1773 Passed, 26 Skipped, 2m 6.59s Total Time |
netbe
approved these changes
May 28, 2025
.../Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationContentViewController.swift
Show resolved
Hide resolved
johnxnguyen
approved these changes
May 28, 2025
zenkins
pushed a commit
that referenced
this pull request
May 28, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Turned out to be that when there are not read messages, when you open conversation, there was a several calls to re-calculate sections at same time which made data, in particular action controllers, not in sync.
actionContollersdict has correct action controller for a message but not insectionController.actionController.Fix is to sync calls to calculate sections using leading and trailing debouncer so at a given moment there is only one calculation.
Testing
As per ticket steps
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: