Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): allow higher version of importlib-resources for python 3.9 and above #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aberlioz
Copy link

@aberlioz aberlioz commented Oct 25, 2024

The pin on version ^5.12.0 of package importlib-resources was introduced in this PR: #60

It prevents applications running on higher versions of python to install the newest importlib-resources versions.

Considering the usage of the lib, one can argue that we don't even need this dependencies for python version 3.9 and above.

References

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@aberlioz
Copy link
Author

Hello @oleg-nenashev 👋🏻 ,
Do you know if someone can please have a look at this 🙏🏻 ?
It should be a very straightforward change.

@oleg-nenashev
Copy link
Member

Cc @leeturner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants