Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix world constraint issues #309

Closed
wants to merge 0 commits into from
Closed

Fix world constraint issues #309

wants to merge 0 commits into from

Conversation

thegrb93
Copy link
Contributor

Will fix: #306 and fix: #187

@dvdvideo1234
Copy link
Contributor

dvdvideo1234 commented Oct 2, 2020 •
edited
Loading

Neat.. I noticed that gmsv_ad2filestream_win32 is not in the repository anymore. Is it still needed or I can delete it from Steam\steamapps\common\GarrysMod\garrysmod\lua\bin?

@thegrb93
Copy link
Contributor Author

thegrb93 commented Oct 2, 2020

Pretty sure its not needed

thegrb93
thegrb93 commented Oct 2, 2020
View reviewed changes
lua/advdupe2/sv_clipboard.lua Outdated
@@ -1076,7 +1076,7 @@ function AdvDupe2.duplicator.Paste( Player, EntityList, ConstraintList, Position
undo.SetPlayer( Player )
undo.Finish()

//if(Tool)then AdvDupe2.FinishPasting(Player, true) end
--if(Tool)then AdvDupe2.FinishPasting(Player, true) end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to delete this line

@dvdvideo1234
Copy link
Contributor

@thegrb93 Any progress on this.. Tell me if I can help somehow ..

@thegrb93
Copy link
Contributor Author

No, I just returned from vacation and fixed some other things. Once I catch up on irl work and have time, I can continue this.

If you want to help, the bug is in this function

advdupe2/lua/advdupe2/sv_clipboard.lua

Line 455 in 8e27851

local function CreateConstraintFromTable(Constraint, EntityList, EntityTable, Player, DontEnable)

Before two props are constrained, they are positioned/angled to their relative locations when the constraint was originally created and then constrained and then returned to their original position/angle. The problem is the world cannot be moved/angled so this fails in some cases.

@dvdvideo1234
Copy link
Contributor

dvdvideo1234 commented Oct 16, 2020 •
edited
Loading

@thegrb93 Maybe this ( constraints between props and world ) will get fixed when Rubat fixed the SANE big. I will test it when I get home.

@dvdvideo1234
Copy link
Contributor

dvdvideo1234 commented Oct 17, 2020 •
edited
Loading

@thegrb93

This problem appears to be fixed also on the pre-release branch. Here is the duplication. Anchor entity is created successfully and the duplication is loaded with no EOF errors.

@thegrb93
Copy link
Contributor Author

Ok that's good. I still need to fix the world rotation issues for other constraints.

@thegrb93 thegrb93 closed this Dec 1, 2020
@thegrb93 thegrb93 force-pushed the fix-world-constraints-offset branch from 8e27851 to 6a51058 Compare December 1, 2020 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@thegrb93 @dvdvideo1234