-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for poetry #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest taking a simpler approach on the CI level here, although the tests are 💯. A few suggestions:
- Run tests on the whole matrix on every push, so that we know our commits work as expected.
- If tests succeed, push image to GHCR tagged with
${github.sha}-{EXPECTED_RELEASE_TAG}
(e.g.95db419-1.7.1-python-3.12-bookworm
) - On release, tag the existing Git SHA tagged image on GHCR with the release version (e.g.
1.7.1-python-3.12-bookworm
)
0612abe
to
b11ea2d
Compare
@parisk Let me know how to proceed from here. What changes do we want to make in the release workflow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a few comments to tidy this up. We should also update the release workflow to just tag the images that already exist in the registry.
b11ea2d
to
e6db167
Compare
@parisk How does pulling of existing images based on the git sha work? Wouldn't the git sha be different for the commit that triggered the |
e6db167
to
5a4ae03
Compare
4f520c8
to
c793cc4
Compare
Nope, it's pretty much the same commit. All releases should happen on the |
262ad78
to
0202d33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. A few more tweaks and we should be good to go!
0202d33
to
e1dc38e
Compare
e1dc38e
to
0e67025
Compare
0e67025
to
b87970e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦌
Resolves #8