feat(data_requests): increase max witnesses on testnet and dev envs #2581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
approved these changes
Jan 27, 2025
Member
|
Could you run the formatter? |
guidiaz
force-pushed
the
data_requests/max_witnesses_on_testnets
branch
from
06f24bb to
2223d30
Compare
guidiaz
force-pushed
the
data_requests/max_witnesses_on_testnets
branch
from
2223d30 to
b4a73d6
Compare
aesedepece
force-pushed
the
master
branch
2 times, most recently
from
1679d32 to
1b59db0
Compare
aesedepece
reviewed
Jul 9, 2025
Comment on lines
+582
to
+585
| match get_environment() { | ||
| Environment::Mainnet => usize::from(dr_output.witnesses) > validator_count / 4, | ||
| _ => usize::from(dr_output.witnesses) > validator_count / 2, | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| match get_environment() { | |
| Environment::Mainnet => usize::from(dr_output.witnesses) > validator_count / 4, | |
| _ => usize::from(dr_output.witnesses) > validator_count / 2, | |
| } | |
| let divider = if let Environment::Mainnet = get_environment() { | |
| 4 | |
| } else { | |
| 2 | |
| } | |
| usize::from(dr_output.witnesses) > validator_count / divider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2580