Fixing yellow warning for UIManager in ReactNative#266
Open
tt-driver-apps wants to merge 1 commit intowix-incubator:masterfrom
Open
Fixing yellow warning for UIManager in ReactNative#266tt-driver-apps wants to merge 1 commit intowix-incubator:masterfrom
tt-driver-apps wants to merge 1 commit intowix-incubator:masterfrom
Conversation
…y in tt-driver-apps for using UIManager.getViewManagerConfig)
tt-driver-apps
changed the title
|
+1 |
donghungx
approved these changes
Mar 31, 2019
| UIManager.dispatchViewManagerCommand( | ||
| ReactNative.findNodeHandle(this), | ||
| UIManager.InteractableView.Commands.bringToFront, | ||
| UIManager.getViewManagerConfig('InteractableView').Commands.bringToFront, |
There was a problem hiding this comment.
i think you should uniq 'InteractableView' string as a constant
|
@tt-driver-apps Is it possible you make the requested changes? I hope it can then be merged into master 👍 |
|
+1 |
|
@tt-driver-apps any chance update PR to the comment, so we can have it merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this library with the latest version of ReactNative (e.g. 0.58) we get the following warning:
Accessing view manager configs directly off UIManager via UIManager['InteractableView'] is no longer supported.This pull request applies the necessary modifications for fixing the problem.