Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on how to block installation based on OS & VCREDIST versions #300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

forderud
Copy link

@forderud forderud commented Oct 10, 2024

Attempt on addressing wixtoolset/issues#8785 and wixtoolset/issues#8786 by extending the WiX documentation to also cover these checks that I believe are quite common.

Disclaimer: This is my first PR to this project and I'm not familiar with "Docusaurus". Therefore, please let me know if the content should be placed elsewhere and if sidebar_position should be changed to a different value. Also, please feel free to be picky on the wording and formatting proposal, and I'll do my best to accommodate the feedback. I can also split the proposal into two separate PRs if desired.

References

Copy link

github-actions bot commented Oct 10, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@forderud
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

wixbot added a commit to wixtoolset/.github that referenced this pull request Oct 10, 2024
@forderud forderud force-pushed the os-vcredist-check branch 3 times, most recently from 47e3e38 to dc68b29 Compare October 10, 2024 10:44
… versions

Attempt on addressing wixtoolset/issues#8785 and wixtoolset/issues#8786 by extending the WiX documentation to also cover these to checks that I believe are quite common.
@forderud
Copy link
Author

@barnson Would it be possible for you to take a look at this documentation update proposal?

@barnson
Copy link
Member

barnson commented Oct 28, 2024

It's in my queue but I'm extra busy atm so it'll be a while yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants