Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A number of minor fixes for WiX v6 #536

Merged
merged 3 commits into from
Dec 27, 2024
Merged

A number of minor fixes for WiX v6 #536

merged 3 commits into from
Dec 27, 2024

Conversation

barnson
Copy link
Member

@barnson barnson commented Jun 30, 2024 •
edited
Loading

@barnson barnson requested a review from robmen June 30, 2024 02:07
@barnson
Copy link
Member Author

barnson commented Jun 30, 2024

@robmen, please look (especially) at 845b9ef.

robmen
robmen requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@robmen robmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might consider sending the other changes through and leave the fix for 845b9ef for more consideration late.

src/wix/WixToolset.Core/Linker.cs Outdated Show resolved Hide resolved
@barnson barnson force-pushed the bob/Fixes.240629 branch from 845b9ef to c597f0e Compare July 15, 2024 19:20
@barnson barnson self-assigned this Sep 3, 2024
@robmen robmen enabled auto-merge (rebase) December 27, 2024 01:10
@robmen robmen self-requested a review December 27, 2024 01:11
@robmen robmen merged commit 701977a into main Dec 27, 2024
3 checks passed
@robmen robmen deleted the bob/Fixes.240629 branch December 27, 2024 01:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robmen robmen robmen approved these changes

Assignees

@barnson barnson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileSearch does not work in a Merge Module Default major upgrade is not working if ProductSearch is used
2 participants
@barnson @robmen