Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option for external secret #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryankmorrow
Copy link

Allow the creation of an external secret from an already existing secret store

@bryankmorrow bryankmorrow requested a review from sudoesnt August 7, 2023 13:34
Copy link

@sudoesnt sudoesnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing to see if I have write access.

@ofirc-wiz
Copy link
Collaborator

Hey @bryankmorrow thanks a lot for the PR!
I recognize the value that this PR brings to the table, I'm wondering though whether we should leave it to the starter kits, e.g.
https://github.com/wiz-sec/kubernetes-starter-kits/pull/2

As the secrets have a different lifecycle than the chart and ESO is yet another 3rd party component, decoupled from Wiz.
What your thoughts on this?

@nxf5025
Copy link

nxf5025 commented Aug 14, 2024

@ofirc-wiz - Seems that starter kit link is dead...However, I'd recommend just doing a generic extraObjects arg like what is proposed in #188. That way it can support other secret management utils like the secrets store csi driver which uses a secretProviderClass without needing a chart update.

This approach has been adopted in many other projects:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants