Change construction of Statement with a Snak parameter.

In WikibaseDataModel 2.0 it is not directly supported anymore thus wrap it in a Claim.
wmde · Oct 15, 2014 · 87f4f66 · 87f4f66
1 parent f3b128d
commit 87f4f66
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 15 deletions.
diff --git a/src/Deserializers/LegacyClaimDeserializer.php b/src/Deserializers/LegacyClaimDeserializer.php
@@ -86,8 +86,7 @@ private function getClaim() {
 
 	private function getStatement() {
 		$statement = new Statement(
-			$this->getMainSnak(),
-			$this->getQualifiers(),
+			new Claim( $this->getMainSnak(), $this->getQualifiers() ),
 			$this->getReferences()
 		);
 

diff --git a/src/Deserializers/LegacyStatementDeserializer.php b/src/Deserializers/LegacyStatementDeserializer.php
@@ -74,8 +74,7 @@ private function newStatement() {
 
 	private function newStatementFromClaim( Claim $claim ) {
 		$statement = new Statement(
-			$claim->getMainSnak(),
-			$claim->getQualifiers()
+			new Claim( $claim->getMainSnak(), $claim->getQualifiers() )
 		);
 
 		$statement->setGuid( $claim->getGuid() );

diff --git a/tests/unit/Deserializers/LegacyClaimDeserializerTest.php b/tests/unit/Deserializers/LegacyClaimDeserializerTest.php
@@ -105,11 +105,13 @@ public function testGivenValidSerialization_deserializeReturnsComplexClaim() {
 
 	public function testGivenValidSerialization_deserializeReturnsStatement() {
 		$statement = new Statement(
-			new PropertyNoValueSnak( 42 ),
-			new SnakList( array(
-				new PropertyNoValueSnak( 23 ),
-				new PropertyNoValueSnak( 1337 ),
-			) ),
+			new Claim(
+				new PropertyNoValueSnak( 42 ),
+				new SnakList( array(
+					new PropertyNoValueSnak( 23 ),
+					new PropertyNoValueSnak( 1337 ),
+				) )
+			),
 			new ReferenceList( array(
 				new Reference(
 					new SnakList( array(

diff --git a/tests/unit/Deserializers/LegacyItemDeserializerTest.php b/tests/unit/Deserializers/LegacyItemDeserializerTest.php
@@ -141,7 +141,7 @@ public function testGivenStatement_itemHasStatement() {
 	}
 
 	private function newStatement() {
-		$statement = new Statement( new PropertyNoValueSnak( 42 ) );
+		$statement = new Statement( new Claim( new PropertyNoValueSnak( 42 ) ) );
 		$statement->setGuid( 'foo' );
 		return $statement;
 	}

diff --git a/tests/unit/Deserializers/LegacyStatementDeserializerTest.php b/tests/unit/Deserializers/LegacyStatementDeserializerTest.php
@@ -76,11 +76,13 @@ public function testGivenInvalidSerialization_deserializeThrowsException( $seria
 
 	public function testGivenValidSerialization_deserializeReturnsStatement() {
 		$statement = new Statement(
-			new PropertyNoValueSnak( 42 ),
-			new SnakList( array(
-				new PropertyNoValueSnak( 23 ),
-				new PropertyNoValueSnak( 1337 ),
-			) ),
+			new Claim(
+				new PropertyNoValueSnak( 42 ),
+				new SnakList( array(
+					new PropertyNoValueSnak( 23 ),
+					new PropertyNoValueSnak( 1337 ),
+				) )
+			),
 			new ReferenceList( array(
 				new Reference(
 					new SnakList( array(