Skip to content

Commit

Permalink
Hook up Soft Close Close Icon
Browse files Browse the repository at this point in the history
Abban committed Nov 20, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 03d1ed0 commit cd0c8de
Showing 4 changed files with 8 additions and 2 deletions.
1 change: 1 addition & 0 deletions banners/english/components/BannerCtrl.vue
Original file line number Diff line number Diff line change
@@ -45,6 +45,7 @@

<SoftClose
v-if="contentState === ContentStates.SoftClosing"
:show-close-icon="true"
@close="() => onClose( 'SoftClose', CloseChoices.Close )"
@maybe-later="() => onClose( 'SoftClose', CloseChoices.MaybeLater )"
@time-out-close="() => onClose( 'SoftClose', CloseChoices.TimeOut )"
1 change: 1 addition & 0 deletions banners/english/components/BannerVar.vue
Original file line number Diff line number Diff line change
@@ -45,6 +45,7 @@

<SoftClose
v-if="contentState === ContentStates.SoftClosing"
:show-close-icon="true"
@close="() => onClose( 'SoftClose', CloseChoices.Close )"
@maybe-later="() => onClose( 'SoftClose', CloseChoices.MaybeLater )"
@time-out-close="() => onClose( 'SoftClose', CloseChoices.TimeOut )"
4 changes: 3 additions & 1 deletion test/banners/english/components/BannerCtrl.spec.ts
Original file line number Diff line number Diff line change
@@ -110,7 +110,9 @@ describe( 'BannerCtrl.vue', () => {
[ 'expectEmitsSoftCloseMaybeLaterEvent' ],
[ 'expectEmitsSoftCloseTimeOutEvent' ],
[ 'expectEmitsBannerContentChangedOnSoftClose' ],
[ 'expectDoesNotShowSoftCloseOnFinalBannerImpression' ]
[ 'expectDoesNotShowSoftCloseOnFinalBannerImpression' ],
[ 'expectShowsCloseIcon' ],
[ 'expectCloseIconEmitsCloseEvent' ]
] )( '%s', async ( testName: string ) => {
await softCloseFeatures[ testName ]( getWrapper() );
} );
4 changes: 3 additions & 1 deletion test/banners/english/components/BannerVar.spec.ts
Original file line number Diff line number Diff line change
@@ -110,7 +110,9 @@ describe( 'BannerVar.vue', () => {
[ 'expectEmitsSoftCloseMaybeLaterEvent' ],
[ 'expectEmitsSoftCloseTimeOutEvent' ],
[ 'expectEmitsBannerContentChangedOnSoftClose' ],
[ 'expectDoesNotShowSoftCloseOnFinalBannerImpression' ]
[ 'expectDoesNotShowSoftCloseOnFinalBannerImpression' ],
[ 'expectShowsCloseIcon' ],
[ 'expectCloseIconEmitsCloseEvent' ]
] )( '%s', async ( testName: string ) => {
await softCloseFeatures[ testName ]( getWrapper() );
} );

0 comments on commit cd0c8de

Please sign in to comment.