Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase language code from item statement #548

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

lucaswerkmeister
Copy link
Member

We now use the property “IETF language tag” for the automatic language code on Wikidata; the subtag of these tags is case-insensitive, but some capitalization is recommended.1, 2 For MediaWiki or Wikidata, on the other hand, the subtags generally need to be all-lowercase (except our special mis-x-Qid codes, see T317863). Reconcile this by lowercasing all language codes from items in the store action.

Bug: T349652

We now use the property “IETF language tag” for the automatic language
code on Wikidata; the subtag of these tags is case-insensitive, but some
capitalization is recommended [1][2]. For MediaWiki or Wikidata, on the
other hand, the subtags generally need to be all-lowercase (except our
special mis-x-Qid codes, see T317863). Reconcile this by lowercasing all
language codes from items in the store action.

[1]: https://en.wikipedia.org/wiki/IETF_language_tag#Syntax_of_language_tags
[2]: https://en.wikipedia.org/w/index.php?title=IETF_language_tag&oldid=1181524280#Syntax_of_language_tags

Bug: T349652
Copy link
Collaborator

@micgro42 micgro42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@lucaswerkmeister lucaswerkmeister merged commit d936d67 into main Oct 31, 2023
3 checks passed
@lucaswerkmeister lucaswerkmeister deleted the lowercase branch October 31, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants