Remove unnecessary onOptionSelected call
#801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for `SpellingVariantInput` was making an unnecessary extra call to `onOptionSelected` when `onInput` was called, to satisfy assertions in the unit test suite that are very involved with the internals of the component eventing logic. This worked okay for codex 1.14.0, but is incompatible with the behaviour changes introduced in Icd4b7ed1e34bf5b2d62f705fdd8c6f4e0cf088d1. Remove the unnecessary call, and remove the unnecessarily detailed unit tests. Bug: T379595
lucaswerkmeister
approved these changes
Nov 15, 2024
lucaswerkmeister
deleted the
bugfix/remove-unnecessary-event-call-20241115
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for
SpellingVariantInputwas making an unnecessary extra call toonOptionSelectedwhenonInputwas called, to satisfy assertions in the unit test suite that are very involved with the internals of the component eventing logic. This worked okay for codex 1.14.0, but is incompatible with the behaviour changes introduced in Icd4b7ed1e34bf5b2d62f705fdd8c6f4e0cf088d1.Remove the unnecessary call, and remove the unnecessarily detailed unit tests.
Bug: T379595