Typescript take two

[RickiJay-WMDE]

Typescript

Where possible, explicit type annotations were added to functions and ambiguously typed variables. Some custom types were defined based on apparent usage; WebDriverIO.Browser was extended to reflect the commands added in default-functions.ts. Configuration files were also changed to Typescript, and deepmerge-ts removed as an explicit dependency (though it remains an implicit one).

getElementByURI

Previously returned [] if a binding with the requested uri was not found. null was easier to check against when actually using the function in queryservice-post-upgrade tests.

editPage

editPage in default-functions.ts is the only place where a submit() method is used directly on a WebDriverIO.Element, which needed to be extended to include a submit() property (though as far as I can tell we aren't defining the method). Additionally, it included a browser.execute() call that passed this as a second parameter. Typescript complained that browser.execute() expected only 1 parameter, so I removed the this. Everything still seems to work.

Custom Types

• Binding: returned by queryBlazeGraphItem
• BotResponse: returned by deleteClaim
• DatabaseConfig: parameter for dbQuery
• ExternalChange: parameter and return type for getDispatchedExternalChange
• LuaCPUValue: returned by getLuaCpuTime
• TestResult and ResultType: used by JsonReporter

skipIfExtensionNotPresent

Most of our tests are written with () => {} format, while skipIfExtensionNotPresent explicitly requires function () {} format. Additionally, I couldn't find a spec file that used skipIfExtensionNotPresent on only one test of several, so I rearranged the spec files to use skipIfExtensionNotPresent in a beforeEach hook rather than in each test. The exception is special-version.ts, which checks against each extension in turn.

[lorenjohnson]

Looks good and tested locally. Everything is happy 🎉