Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect #598

Merged
merged 27 commits into from
Mar 4, 2024
Merged

Expect #598

merged 27 commits into from
Mar 4, 2024

Conversation

RickiJay-WMDE
Copy link
Member

@RickiJay-WMDE RickiJay-WMDE commented Mar 2, 2024 •
edited
Loading

Replaces assert with expect for consistency's sake

@RickiJay-WMDE RickiJay-WMDE marked this pull request as ready for review March 2, 2024 11:12
@RickiJay-WMDE RickiJay-WMDE requested a review from a team March 2, 2024 11:12
rti
rti requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@rti rti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, really getting into shape this thing, thanks for your work

test/specs/elasticsearch/elasticsearch.ts Outdated Show resolved Hide resolved
test/specs/upgrade/queryservice-post-upgrade.ts Show resolved Hide resolved
@RickiJay-WMDE RickiJay-WMDE requested a review from rti March 4, 2024 11:51
@RickiJay-WMDE RickiJay-WMDE merged commit cfdc461 into main Mar 4, 2024
28 checks passed
@RickiJay-WMDE RickiJay-WMDE deleted the expect branch March 4, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rti rti rti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RickiJay-WMDE @rti