-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add wikibase-lts and deploy-lts products #813
base: main
Are you sure you want to change the base?
Conversation
A couple of notes after looking into things a bit more today:
|
|
||
### 🏡 Chore | ||
|
||
- bump mediawiki to 1.42.3, bump extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- bump mediawiki to 1.42.3, bump extensions | |
- bump mediawiki to 1.39.10, bump extensions |
|
||
- bump mediawiki to 1.42.3, bump extensions | ||
|
||
## (from **wikibase@3.0.1** (2024-10-09)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure whether we really want to include this information. Going forward, NX wouldn't generate it either. I think I would prefer just the list of changes since wikibase-lts@1.0.0
|
||
### 📖 Documentation | ||
|
||
- Link to MediaWiki bundled extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to spell it out once here: So whenever we change something on the wikibase product in the future, we always have to consider bringing it to lts too, right when we implement the change, review and merge it. In case we decide the change goes to latest and lts, we would apply the same change to both directories in the same PR, so NX would generate the same changelog entry for any of the both products whenever we release the next version.
I like this.
I am still sympathizing with the idea to make wikibase and wikibase-lts one product on dockerhub. This is how the process could look like:
The switch from "released from So users could onboard to Wikibase 4 now as soon as we release it and keep using it for years as long as we keep it in lts support. That we change the build folder name over time would not be relevant for the user. I do agree though, that we need some special handling for the This is raw thoughts dumped here, I might be missing something, or even a whole lot. The purpose of this comment is to further fuel the discussion. |
After more discussion the conclusion for now is to keep the wikibase naming for the product for both git tags and docker hub releases. This requires maybe only adding an exception here: wikibase-release-pipeline/build/build.sh Line 75 in 1f8648f
...for wikibase-lts to make the IMAGE_NAME wikibase |
Moves our Wikibase and Deploy LTS products beside our main releases of these products all in one repo. This reduces complexity, and solves a number of problems. The work in this branch completes much of what is needed to take this path, with the following remaining to be decided/addressed.
nx affected
.Note: This branch includes a the yet unreleased Wikibase LTS 1.0.1 (MediaWiki 1.39.10 patch release), and the related Deploy LTS 1.0.1 releases already prepared including CHANGELOG updates (review those to see the format used).