Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: nx release and publish #825

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

rti
Copy link
Contributor

@rti rti commented Feb 3, 2025

About

Add some documentation on how to use nx for releasing locally

Status

ready to be reviewed and merged just like this

Dependencies

none

@rti rti requested a review from a team February 3, 2025 07:53
@rti rti force-pushed the add-some-docs-about-nx-to-readme branch from 61b0951 to 42d0f31 Compare February 4, 2025 03:59
Copy link
Contributor

@lorenjohnson lorenjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 More or less I think this is the best way forward to make releases, but am wondering

# changelog and package.json adjustments will be created locally. This should
# happen on `main`. Also, a new git tag with the new version of the released
# project will be created locally.
./nx release -p wikibase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally am a fan of orchestrating releases locally in this way, but how does this square with our current GHA setup for these things? Let's catch-up about it on today's meeting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A release can be created just like this locally, or, in GHA using our 📦 Create a WBS Release workflow.

Both paths will generate a release commit (ideally on main) and a tag. With the former you have to push from local to origin/main (works because we are all admins), the latter will push to main using our Wikibase Suite Bot.

As soon as the tag arrives, GHA will trigger 📦 Build and Publish a WBS Image Release to Dockerhub to publish to dockerhub in case of an image release.

@rti rti requested a review from lorenjohnson March 11, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants