simplify response handling and improve api constant name

wmde · Feb 23, 2024 · 8cc8b6f · 8cc8b6f
1 parent 91437ee
commit 8cc8b6f
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/resources/js/Components/LanguageSelector.vue b/resources/js/Components/LanguageSelector.vue
@@ -47,7 +47,7 @@ import languageData from "@wikimedia/language-data";
 const searchInput: Ref<string> = ref('');
 const highlightedIndex: Ref<number> = ref(-1);
 const closeUrl = ref(closeUrlSvg);
-const apiSearchInput = ref(['']);
+const apiLanguageCodes = ref(['']);
 
 const input = ref<InstanceType<typeof LanguageSelectorInput> | null>(null);
 
@@ -64,11 +64,11 @@ const languages = computed<Language[]>(() => {
 });
 
 const shownLanguages = computed<Language[]>(() => {
-	return languages.value.filter((language) =>
-		language.code.startsWith(
-            searchInput.value.toLowerCase() ) ||
-		language.autonym.toLowerCase().includes(
-            searchInput.value.toLowerCase()) || apiSearchInput.value.includes(language.code))
+    return languages.value.filter((language) =>
+        language.code.startsWith(searchInput.value.toLowerCase()) ||
+        language.autonym.toLowerCase().includes(searchInput.value.toLowerCase()) ||
+        apiLanguageCodes.value.includes(language.code)
+    )
 });
 
 function onInput(searchedLanguage: string): void {
@@ -83,14 +83,11 @@ async function getApiLanguageCodes(inputValue: string) {
         {
             params: {
                 search: inputValue,
-                origin:'*' // avoid CORS console errors
+                origin: '*' // avoid CORS console errors
             }
         }).then((response) => {
-          const languageCodes = Object.keys(response.data.languagesearch);
-          languageCodes.forEach(languageCode => {
-            apiSearchInput.value.push(languageCode);
-          });
-      }) ;
+            apiLanguageCodes.value = Object.keys(response.data.languagesearch);
+        });
 }
 
 function onSelect(languageCode: string): void {