Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#209 update with edits as submitted to LSP #210

Merged
merged 18 commits into from
Aug 2, 2024
Merged

#209 update with edits as submitted to LSP #210

merged 18 commits into from
Aug 2, 2024

Conversation

amilan17
Copy link
Member

@amilan17 amilan17 linked an issue Jul 23, 2024 that may be closed by this pull request
update main and publication with changes as submitted to LSP #209
Closed
@amilan17 amilan17 marked this pull request as draft July 23, 2024 15:04
@amilan17
Copy link
Member Author

amilan17 commented Jul 23, 2024 •
edited
Loading

@tomkralidis - please review the changes in clause 7 and ignore the other diffs.
2eec0e8

Let me know if this solution of suppressing "sectnums' in clause 7 works for you.

@amilan17 amilan17 marked this pull request as ready for review July 26, 2024 07:34
tomkralidis
tomkralidis requested changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@tomkralidis tomkralidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See change requests. As well, need to review/assess #214/#215 in relation to this PR.

standard/sections/clause_7_normative_text.adoc Outdated Show resolved Hide resolved
standard/sections/clause_8_gdc.adoc Show resolved Hide resolved
@tomkralidis tomkralidis force-pushed the 209-update-with-edits-for-LSP branch from b6b4c10 to 683df56 Compare August 2, 2024 10:54
@tomkralidis tomkralidis merged commit 0526584 into main Aug 2, 2024
@tomkralidis tomkralidis deleted the 209-update-with-edits-for-LSP branch August 2, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkralidis tomkralidis tomkralidis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update main and publication with changes as submitted to LSP
2 participants
@amilan17 @tomkralidis