Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GTS-headers using CSV file to map filepath with headers and updated downloader functionality #691

Merged
merged 22 commits into from
Jun 23, 2024
Merged

add GTS-headers using CSV file to map filepath with headers and updated downloader functionality #691

merged 22 commits into from
Jun 23, 2024

Conversation

maaikelimper
Copy link
Collaborator

@maaikelimper maaikelimper marked this pull request as ready for review June 10, 2024 06:36
tomkralidis
tomkralidis requested changes Jun 13, 2024
View reviewed changes
wis2box-management/wis2box/data/base.py Show resolved Hide resolved
docs/source/user/gts-headers-in-wis2.rst Outdated

To enable the WIS2 to GTS Gateway to correctly identify the data to be republished on the GTS, you need to include the GTS property in the WIS2 Notification Message as follows:

```json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs rST (not Markdown) formatting).

docs/source/user/gts-headers-in-wis2.rst Outdated Show resolved Hide resolved
@tomkralidis tomkralidis reopened this Jun 13, 2024
@maaikelimper
Merge pull request #694 from wmo-im/main
cc63b99 
add latest commits to gts-headers-mapping PR
@maaikelimper
gts-headers-mappings plus download updates (#695)
03d7053 
* add download tests, wis2box commands, updated dashboards
@maaikelimper maaikelimper requested review from david-i-berry and removed request for efucile June 14, 2024 08:57
@maaikelimper maaikelimper changed the title add GTS-headers using CSV file to map filepath with headers add GTS-headers using CSV file to map filepath with headers and updated downloader functionality Jun 14, 2024
@maaikelimper
Copy link
Collaborator Author

Changes were made in wis2downloader that prevented the GHA on this PR to complete.

I've decided to add the changes to fix the wis2downloader to this PR and I will close #693

I will all the suggestions from Dave in PR 693 to this PR

@maaikelimper
Copy link
Collaborator Author

@tomkralidis the downloader CLI commands have been removed

@tomkralidis tomkralidis merged commit dc404a9 into main Jun 23, 2024
3 checks passed
@tomkralidis tomkralidis added this to the sprint-015 milestone Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-i-berry david-i-berry david-i-berry left review comments

@tomkralidis tomkralidis tomkralidis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sprint-015
Development

Successfully merging this pull request may close these issues.
3 participants
@maaikelimper @tomkralidis @david-i-berry