Skip to content

Commit

Permalink
😶 Oops
Browse files Browse the repository at this point in the history
  • Loading branch information
wobbier committed Feb 23, 2024
1 parent 51e8d8d commit 1b65886
Show file tree
Hide file tree
Showing 12 changed files with 28 additions and 15 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/macOS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:

- name: Generate a new project
shell: bash
run: cd Project && sh GenerateSolution.command && cd ../
run: cd Project && sh GenerateSolution.command && cd ../ && ls

- name: Build Editor
if: ${{ matrix.type == 'Editor' }}
Expand All @@ -54,6 +54,7 @@ jobs:
action: build # default = `test`
code-coverage: true # default = `false`
warnings-as-errors: false # default = `false`
workspace: EmptyProject.xcworkspace
configuration: ${{ matrix.type }}_${{ matrix.configuration }} # no default, ie. `xcodebuild` decides itself
scheme: Havana_mac

Expand All @@ -66,6 +67,7 @@ jobs:
action: build # default = `test`
code-coverage: true # default = `false`
warnings-as-errors: false # default = `false`
workspace: EmptyProject.xcworkspace
configuration: ${{ matrix.type }}_${{ matrix.configuration }} # no default, ie. `xcodebuild` decides itself
scheme: Game_EntryPoint_mac

Expand Down
2 changes: 1 addition & 1 deletion Modules/Dementia/Source/Math/Frustrum.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#include "Vector2.h"

#include "Matrix4.h"
#include "glm\detail\type_vec.hpp"
#include <glm/glm.hpp>

class Frustum
{
Expand Down
6 changes: 3 additions & 3 deletions Modules/Moonlight/Source/Graphics/ShaderFile.h
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,9 @@ struct ShaderFileMetadata
exportType = "vertex";
}

std::string fileName = FilePath.GetLocalPath().substr( FilePath.GetLocalPath().rfind( "/" ) + 1, FilePath.GetLocalPath().length() );

std::string localFolder = FilePath.GetLocalPath().substr( 0, FilePath.GetLocalPath().rfind( "/" ) + 1 );
// #TODO: Do I need this local string shit?
std::string fileName = FilePath.GetLocalPathString().substr( FilePath.GetLocalPathString().rfind( "/" ) + 1, FilePath.GetLocalPathString().length() );
std::string localFolder = FilePath.GetLocalPathString().substr( 0, FilePath.GetLocalPathString().rfind( "/" ) + 1 );

std::string nameNoExt = fileName.substr( 0, fileName.rfind( "." ) );
std::string progArgs = "\"" + shadercPath.FullPath + "\" -f ../../";
Expand Down
4 changes: 2 additions & 2 deletions Modules/Moonlight/Source/Graphics/Texture.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,8 @@ void TextureResourceMetadata::Export()

// texturec -f $in -o $out -t bc2 -m
std::string progArgs = "\"" + optickPath.FullPath + "\" -f ../../";
progArgs += FilePath.LocalPath;
progArgs += " -o \"../../" + FilePath.LocalPath + ".dds\"" + exportType;
progArgs += FilePath.GetLocalPathString();
progArgs += " -o \"../../" + FilePath.GetLocalPathString() + ".dds\"" + exportType;
system( progArgs.c_str() );

#endif
Expand Down
3 changes: 2 additions & 1 deletion Source/Cores/Rendering/RenderCore.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,8 @@ void RenderCore::Update( const UpdateContext& inUpdateContext )

for( Moonlight::CameraData& cam : cameras.Commands )
{
if( cam.ViewFrustum.IsPointInFrustum( glm::vec4(meshMatrix[3] ) ) )
glm::vec4 point = glm::vec4( meshMatrix[3] );
if( cam.ViewFrustum.IsPointInFrustum( point ) )
{
isVisible = true;
cam.VisibleFlags[entIndex] = true;
Expand Down
3 changes: 2 additions & 1 deletion Source/Engine/Engine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,9 @@ void Engine::Init( Game* game )

// Register systems
{
updateContext.m_SystemRegistry->RegisterSystem( NewRenderer );
systemRegistry.RegisterSystem( NewRenderer );
}
updateContext.m_SystemRegistry = &systemRegistry;

m_isInitialized = true;
}
Expand Down
1 change: 1 addition & 0 deletions Source/Engine/Engine.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ class Engine
JobEngine newJobSystem;

EngineUpdateContext updateContext;
SystemRegistry systemRegistry;

#if USING( ME_EDITOR )
Input m_editorInput;
Expand Down
2 changes: 1 addition & 1 deletion Source/UI/Graphics/GPUDriver.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "PCH.h"
#include "GPUDriver.h"
#include "Utils\BGFXUtils.h"
#include <Utils/BGFXUtils.h>
#include "bimg\decode.h"
#include "Core\Assert.h"
#include "Device\FrameBuffer.h"
Expand Down
2 changes: 1 addition & 1 deletion Source/UI/UIUtils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

#if USING( ME_ULTRALIGHT )

#include "Ultralight\KeyCodes.h"
#include <Ultralight/KeyCodes.h>

bool UIUtils::ConvertToULChar( KeyCode inKeyCode, int& outULKeyCode )
{
Expand Down
2 changes: 1 addition & 1 deletion Source/UI/UIUtils.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#pragma once
#include "Engine\Input.h"
#include <Engine/Input.h>

namespace UIUtils
{
Expand Down
3 changes: 1 addition & 2 deletions Source/UI/UIWindow.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ class UIWindow
: public ultralight::Window
, public ultralight::RefCountedImpl<UIWindow>
{
friend class ultralight::OverlayImpl;
friend class ultralight::Window;
friend class ultralight::OverlayImpl;
//friend class ultralight::OverlayImpl;
public:
UIWindow( IWindow* window, ultralight::OverlayManager* manager );
protected:
Expand Down
11 changes: 10 additions & 1 deletion Tools/BaseProject.sharpmake.cs
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,18 @@ public virtual void ConfigureRelease(Configuration conf, CommonTarget target)
{
conf.DefaultOption = Options.DefaultTarget.Release;
conf.Options.Add(Sharpmake.Options.Vc.Compiler.RuntimeLibrary.MultiThreadedDLL);
conf.Options.Add(Options.Vc.General.DebugInformation.ProgramDatabase);
conf.Options.Add(Options.Vc.Compiler.Inline.OnlyInline);
conf.AdditionalCompilerOptions.Add("/Zi");
conf.Defines.Add("DEFINE_ME_RELEASE");

if (conf.Platform == Platform.win64 )
{
conf.AdditionalCompilerOptions.Add("/Zi");
}
else if (conf.Platform == Platform.mac)
{
conf.AdditionalCompilerOptions.Add("-g");
}
}


Expand Down

0 comments on commit 1b65886

Please sign in to comment.