Support for Routing Instances #21
Conversation
this allows for custom serializing and deserializing
| @@ -23,6 +24,8 @@ pub async fn run_peer( | |||
| let mut caps = vec
There was a problem hiding this comment.
Needs the additional capabilities for the add_path case too
There was a problem hiding this comment.
I've added them; unfortunately I don't have a setup to test add-path.
src/store.rs
Outdated
| let rd = RouteDistinguisher::try_from(labeled.prefix.rd.clone()) | ||
| .inspect_err(|_| warn!("invalid Bgp Route distinguisher")) | ||
| .ok()?; | ||
| match Ipv4Net::new(prefix.addr, prefix.prefixlen) { |
There was a problem hiding this comment.
At this point the ipv4net and ipv6net parsing can be moved to an external function
frontend/src/search.js
Outdated
| <option value=${name} ?selected=${(new URLSearchParams(optionsString)).get("Router") === name}>on ${name}</option> | ||
| `)} | ||
| </select> | ||
| <select name="table-sel" id="table-sel" @change=${() => document.getElementById("input-submit").click()}> |
There was a problem hiding this comment.
I would like this field to be hidden when only a single routing instance is known to fernglas (or, alternatively, when the only routing instance is the default instance).
There was a problem hiding this comment.
makes sense: now it's only displayed when there are more than one routing-instances.
previously introduced commits introduced a usage of inspect_err, which was not available in older versions of rust stable.
Istvan91
force-pushed
the
routing-instance-support
branch
from
8ef256f to
11ddc63
Compare
|
Hi, sorry for the long delay. I can not properly test this at the moment (or for a while), but we'll just take it as-is and then fix any breakages as they appear. |
|
Thanks! |
This MR enhances fernglas to support routing-instances for BGP and BMP Sessions. Following three methods to gather routing-instance information have been implemented:
There has been a breaking change in the API to expose the routing-instance information. The frontend has been updated accordingly.
Possible outstanding improvement: Make Routing-Instance names configurable. Currently the Route-Distinguisher associated with the routing-instance is used as the name.