Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose.yml with frequently used environment variables … #556

Closed
wants to merge 2 commits into from

Conversation

iVegas
Copy link
Contributor

@iVegas iVegas commented Sep 8, 2023

…for php container

@iVegas
Copy link
Contributor Author

iVegas commented Sep 8, 2023

closes #507
closes #508

@csandanov
Copy link
Member

Hi, why set log level to 0? We probably do need to change the default to 3

@iVegas
Copy link
Contributor Author

iVegas commented Sep 19, 2023

The php image already uses the default log level value if xdebug is enabled.
In case I want to change the log level I'll uncomment the line and set a different log level.
Unless xdebux connection is not configured by a developer default value is enough to help establish it. Once IDE listens to the web server correctly logging is no longer needed.
So frequently used values for xdebug logger level are 3 or 0. That`s why I provided a different to the default value for the xdebug logging level.

docker-compose.yml Outdated Show resolved Hide resolved
@csandanov
Copy link
Member

Unless xdebux connection is not configured by a developer default value is enough to help establish it.

The current default log level is 7 which information, I guess it makes sense to change it to 3 (warnings), change it directly in the wodby/php image, not just here through env vars

@iVegas
Copy link
Contributor Author

iVegas commented Sep 22, 2023

Added related PR wodby/php#184

That will be resolved here wodby/php#184
@iVegas iVegas closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants