Use a pyproject.toml #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It make it easier to install directly with a `pip install git+https://github.com/Baduit/cydoomgenericr`
The setup.py now only contains stuff related to the cython extension.
wojciech-graj
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Thanks a bunch for this! I started converting my python projects to use pyproject.toml recently, but I hadn't gotten around to cydoomgeneric yet, so this is a very welcome change.
Before I merge, I'd appreciate if you could fix the workflow file per the comment I left, and add a line under line 2 in setup.py with the contents Copyright(C) 2024 <YOUR NAME>
.github/workflows/python-package.yml
Outdated
| @@ -24,12 +24,15 @@ jobs: | |||
| uses: actions/setup-python@v3 | |||
| with: | |||
| python-version: ${{ matrix.python-version }} | |||
| - name: Install dependencies | |||
| - name: Install cydoomgeneric | |||
| working-directory: ${{github.workspace}}/cydoomgeneric | |||
There was a problem hiding this comment.
Either working-directory: ${{github.workspace}}, or this line might be completely redundant
There was a problem hiding this comment.
Indeed , there is no need to set the working-directory as the setup.py and pyproject.toml are at the top level
There is no need to install the requirements manually, with the pyproject.toml it is done automatically Use the modern replacement for buildind wheels (instead of the python setup.py bdist_wheel)
wojciech-graj
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a pyproject.toml is now the way to go. The setup.py can still be used then the build backend is setuptools, especially for dynamic fields (in this case the C Extension a different flags depending on the platform)