-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated and added new macros in chapter 02, Features Defined as C Pre-processor Macro. #139
Merged
JacobBarthelmeh
merged 11 commits into
wolfSSL:master
from
aidangarske:chapter02-pre-processor-macros
Jun 25, 2024
Merged
Updated and added new macros in chapter 02, Features Defined as C Pre-processor Macro. #139
JacobBarthelmeh
merged 11 commits into
wolfSSL:master
from
aidangarske:chapter02-pre-processor-macros
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ition, I also created a shared wolfSSL Macro Documentation sheets in hopes that it can be updated as new macros are created so we have an ongoing, easy to reference list. Here is the link that can only be accessed by being apart of the wolfSSL engineering shared drive: https://docs.google.com/spreadsheets/d/10rEf_mU7xul9BoIebyhasugUxSXVuHXhkkb7bnbtjXA/edit?usp=sharing
douzzer
previously requested changes
Jun 15, 2024
…ition, I also created a shared wolfSSL Macro Documentation sheets in hopes that it can be updated as new macros are created so we have an ongoing, easy to reference list. Here is the link that can only be accessed by being apart of the wolfSSL engineering shared drive: https://docs.google.com/spreadsheets/d/10rEf_mU7xul9BoIebyhasugUxSXVuHXhkkb7bnbtjXA/edit?usp=sharing - spelling fixes and corrections.
dgarske
requested changes
Jun 17, 2024
dgarske
requested changes
Jun 17, 2024
dgarske
requested changes
Jun 17, 2024
dgarske
requested changes
Jun 17, 2024
dgarske
requested changes
Jun 17, 2024
…ke/documentation into chapter02-pre-processor-macros # Conflicts: # wolfSSL/src/chapter02.md
dgarske
requested changes
Jun 21, 2024
dgarske
requested changes
Jun 21, 2024
dgarske
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last round. Finished reviewing it all.
dgarske
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Aidan. Over to wolfssl-bot -> @JacobBarthelmeh to finalize.
JacobBarthelmeh
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated and added new macros in chapter 02, Features Defined as C Pre-processor Macro. In addition, I also created a shared wolfSSL Macro Documentation sheets in hopes that it can be updated as new macros are created so we have an ongoing, easy to reference list.
Here is the link that can only be accessed by being apart of the wolfSSL engineering shared drive:
https://docs.google.com/spreadsheets/d/10rEf_mU7xul9BoIebyhasugUxSXVuHXhkkb7bnbtjXA/edit?usp=sharing