Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync file structures (en/ja) #160

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

tamasan238
Copy link
Member

The build would fail in cases where some of the source files did not have a Japanese version.
This problem has been fixed.
Additionally, the indentation has been corrected.

@tamasan238
Copy link
Member Author

@bandi13 please review this PR.

@bandi13
Copy link
Contributor

bandi13 commented Aug 21, 2024

This does not make sense to me. The Japanese versions would have different chapter numberings and no appendix? Seems like the Appendix needs to be translated, or at least have a place holder for the files.

@tamasan238
Copy link
Member Author

I understood that thought. That's true.
I've sent the details to Slack, so let us discuss it there.

@tamasan238 tamasan238 changed the title Clarify the build target for the JP ver. Sync file structures (en/ja) Aug 25, 2024
Copy link
Contributor

@bandi13 bandi13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@bandi13 bandi13 merged commit 9545dc1 into wolfSSL:master Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants