Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anti-glitch armor: Added clobbers to assembly #430

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Anti-glitch armor: Added clobbers to assembly #430

merged 2 commits into from
Apr 11, 2024

Conversation

danielinux
Copy link
Member

Possible fix for ZD17804.

User reports that r7 is being reused for an intermediate assignment translating a mov from memory. Proper clobbering should prevent that from happening.

@danielinux danielinux assigned rizlik and unassigned rizlik Apr 10, 2024
@danielinux danielinux marked this pull request as ready for review April 11, 2024 07:08
rizlik
rizlik reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@rizlik rizlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be pedantic but I think it's also a good idea to add "cc" to the clobbers list for instructions that modify processor flags (and, cmp, lsls).

@danielinux danielinux requested a review from rizlik April 11, 2024 10:39
@rizlik rizlik merged commit 1ba099a into wolfSSL:master Apr 11, 2024
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rizlik rizlik rizlik approved these changes

Assignees

@rizlik rizlik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielinux @rizlik