Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added client-tls-http.c example #353

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

yota22721
Copy link

No description provided.

@kojo1 kojo1 self-requested a review December 14, 2022 01:51
tls/client-tls-http.c Outdated Show resolved Hide resolved
@kojo1 kojo1 requested a review from cconlon December 15, 2022 00:25
@yota22721 yota22721 requested review from kojo1 and removed request for cconlon December 15, 2022 03:27
@kojo1 kojo1 requested a review from cconlon December 15, 2022 04:12
@cconlon cconlon self-assigned this Mar 8, 2023
tls/client-tls-http.c Outdated Show resolved Hide resolved
tls/client-tls-http.c Outdated Show resolved Hide resolved
tls/client-tls-http.c Outdated Show resolved Hide resolved
tls/client-tls-http.c Outdated Show resolved Hide resolved
/* Connect to wolfSSL on the server side */
if ((ret = wolfSSL_connect(ssl)) != SSL_SUCCESS) {
fprintf(stderr, "ERROR: failed to connect to wolfSSL\n");
printf("%d\n",ret);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need this printf for ret. On failure, wolfSSL_connect will just return SSL_FAILURE. If you want to print the specific error, please call wolfSSL_get_error(ssl, ret), then print out the return of that function.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted unnecessary debug printf at 446f0a7.

@cconlon cconlon assigned yota22721 and unassigned cconlon Mar 17, 2023
@yota22721 yota22721 requested review from cconlon and removed request for kojo1 March 29, 2023 07:00
@yota22721
Copy link
Author

  • Updated copyright to 2025
  • Deleted unused debug printf
  • Added space after commas and #include

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants