Added client-tls-smtp-overssl.c and client-tls-smtp-starttls.c #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add client-tls-smtp-overssl.c Add client-tls-smtp-overssl.c
Add client-tls-smtp-starttls.c Added client-tls-smtp
yota22721
changed the title
Add client-tls-smtp-overssl.c Add client-tls-smtp-overssl.c
Add client-tls-smtp-starttls.c Added client-tls-smtp
dgarske
requested changes
Jan 20, 2023
tls/client-tls.c
Outdated
| @@ -82,7 +82,7 @@ int main(int argc, char** argv) | |||
| ret = -1; | |||
| goto end; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please revert this whitespace addition.
tls/client-tls-smtp-starttls.c
Outdated
| close(sockfd); /* Close the connection to the server */ | ||
| end: | ||
| return ret; /* Return reporting a success */ | ||
| } |
There was a problem hiding this comment.
Please add extra newline to end of file. Should be one at end. Thanks
tls/client-tls-smtp-starttls.c
Outdated
| #include <wolfssl/ssl.h> | ||
| #include <wolfssl/wolfcrypt/coding.h> | ||
|
|
||
| /*smtp starttls commands */ |
tls/client-tls-smtp-overssl.c
Outdated
| } | ||
|
|
||
| /* Encode the mail to Base64 */ | ||
| word32 outLen = sizeof(buff); |
There was a problem hiding this comment.
Can't mix variable declarations in code. Must be top of function or in a brace section.
tls/client-tls-smtp-overssl.c
Outdated
| goto cleanup; | ||
| } | ||
| /* Get the right mail address length */ | ||
| for(len=0;len<sizeof(plain);len++){ |
There was a problem hiding this comment.
Add spaces for (len=0; len<sizeof(plain); len++) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.