-
Notifications
You must be signed in to change notification settings - Fork 186
TLS 1.3 certificate_authorities extension in ClientHello #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS 1.3 certificate_authorities extension in ClientHello #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds example implementations showcasing the TLS 1.3 certificate_authorities extension in ClientHello messages. The examples demonstrate how clients can indicate supported certificate authorities to guide server certificate selection.
- Adds a complete TLS 1.3 server example that responds to certificate_authorities extensions
- Adds a corresponding client example that sends certificate_authorities extensions
- Implements dynamic certificate selection based on client-provided CA names
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
tls/server-tls13-certauth-c2s.c | Server implementation with certificate selection callback based on client CA names |
tls/client-tls13-certauth-c2s.c | Client implementation that sends certificate_authorities extension in ClientHello |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ce02161
to
fefad7d
Compare
fefad7d
to
f4ecf7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples should be minimal pieces of code showcasing only a set of features. Comments about "bloat" refer to features that are not relevant to CA lists.
I ran the examples and everything looks to work.
@julek-wolfssl That's not code written by me. I took
The changes you're suggesting are not on things that I added, they're also present in |
Thanks for pointing that out. I still think that its better to remove these sections because we already have default secret callbacks in wolfssl so these callbacks are not necessary. Removing the callbacks cuts out ~80 lines from each example. |
Alright. Should I do that on these new files only or on other files that do this too? |
Only on new files for now. You can add a note to the README if you want to be extra thoughtful. |
This adds an example for the TLS 1.3 certificate_authorities extension in ClientHello.
This was newly implemented in wolfSSL/wolfssl#9209. Should wait for that to be merged before this.