Skip to content

Fix building ML-KEM and LMS with cmake #8639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025
Merged

Conversation

anhu
Copy link
Member

@anhu anhu commented Apr 4, 2025

Fixes ZD 19653

Testing

mkdir build && cd build && cmake -DWOLFSSL_MLKEM=1 -DWOLFSSL_EXPERIMENTAL=1 .. && make all

mkdir build && cd build && cmake -DWOLFSSL_LMS=1 -DWOLFSSL_EXPERIMENTAL=1 .. && make all

mkdir build && cd build && cmake -DWOLFSSL_LMS=1 -DWOLFSSL_LMSSHA256192=1 -DWOLFSSL_EXPERIMENTAL=1 .. && make all

@anhu
Copy link
Member Author

anhu commented Apr 5, 2025

jenkins retest this please.

@anhu anhu requested review from SparkiDev and wolfSSL-Bot April 7, 2025 14:45
@anhu anhu self-assigned this Apr 7, 2025
SparkiDev
SparkiDev previously approved these changes Apr 8, 2025
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test(s) for this in .github/workflows/cmake.yml?

@gojimmypi
Copy link
Contributor

Jenkins retest this please

for long running jobs I cancelled

@gojimmypi
Copy link
Contributor

gojimmypi commented Apr 13, 2025

Manually cancelled 7371 and PRB 8583 (all nodes offline) after running for 10 hours

@dgarske
Copy link
Contributor

dgarske commented Apr 15, 2025

Retest this please: "PRB-single-flag.txt_135" "Found unhandled org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException exception"

@anhu
Copy link
Member Author

anhu commented Apr 15, 2025

If satisfactory, please merge.
Warm regards, Anthony

Copy link
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with cmake -DWOLFSSL_MLKEM=1 -DWOLFSSL_LMS=1 -DWOLFSSL_LMSSHA256192=1 -DWOLFSSL_XMSS=1 -DWOLFSSL_EXPERIMENTAL=1

@douzzer douzzer merged commit f6434cf into wolfSSL:master Apr 15, 2025
186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants