Rust wrapper: add wolfssl::wolfcrypt::ed448 module #9379
Merged
+1,460
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holtrop
commented
Nov 4, 2025
gasbytes
requested changes
Nov 4, 2025
Contributor
gasbytes
left a comment
gasbytes
left a comment
There was a problem hiding this comment.
LGTM, just some minor changes mainly in the documentation.
gasbytes
approved these changes
Nov 5, 2025
Contributor
|
Does this code differ much from ed25519.rs? |
Contributor
Author
No it is very similar. Each function calls a different C API function, but the logic is pretty much the same for each. ed25519 has 'ctx' versions of sign_msg and verify_msg which are not present in ed448 because the main sign_msg and verify_msg functions take a context pointer. |
SparkiDev
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rust wrapper: add wolfssl::wolfcrypt::ed448 module
Testing
Unit tests.
Checklist