Fix Coverity dead code report #9476
Open
+8
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Coverity dead code reports by removing redundant runtime checks for the align variable inside preprocessor blocks where WOLFSSL_GENERAL_ALIGNMENT > 0. Since WOLFSSL_GENERAL_ALIGNMENT is defined as either 0, 4, or 16 in settings.h, when the preprocessor condition evaluates to true, the align variable is guaranteed to be non-zero, making the runtime if (align) checks dead code.
- Removes redundant
if (align)checks inside#if WOLFSSL_GENERAL_ALIGNMENT > 0blocks - Adds proper
#elsebranches to handle the case whenWOLFSSL_GENERAL_ALIGNMENTis 0 - Applies fixes to two similar functions:
GrowAnOutputBuffer()andGrowOutputBuffer()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SparkiDev
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix cases where code uses
WOLFSSL_GENERAL_ALIGNMENTas a compiler conditionalFixes zd20515
Testing
customer confirmed
Checklist