JNI/JSSE: call wolfSSL_sk_X509_pop_free() in WolfSSLX509StoreCtx.getDerCerts() #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…free() in WolfSSLX509StoreCtx.getDerCerts()
cconlon
assigned cconlon, wolfSSL-Bot and JacobBarthelmeh and unassigned cconlon and JacobBarthelmeh
douzzer
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the free function called in
WolfSSLX509StoreCtx.getDerCerts()when freeing theWOLFSSL_STACK*allocated withwolfSSL_X509_STORE_GetCerts(WOLFSSL_X509_STORE_CTX*).wolfSSL_sk_X509_free()just frees the stack structure, wherewolfSSL_sk_X509_pop_free()frees each node in the stack then the stack.WolfSSLX509StoreCtx.getDerCerts()is called inside theWolfSSLInternalVerifyCbclass'verifyCallback()method, which will be called when peer verification is conducted inside an SSL/TLS connection with wolfJSSE.