SSLEngine fixes around HandshakeStatus, beginHandshake(), and alerts #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ived after handshake has completed
…r, renegotiation not supported
cconlon
force-pushed
the
sslEngineFixesMay2024
branch
from
c063dfa
to
5b31cf2
Compare
…sionIsResumable()
…ing one in WolfSSLAuthStore.getSession()
JacobBarthelmeh
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a few various fixes for
SSLEngineincluding:HandshakeStatus.FINISHEDfor session tickets being received after the handshake has completed. Otherwise this may put callers into an odd state when the handshake has not finished yet.beginHandshake()more than once can be done to instigate renegotiation. Since wolfJSSE SSLEngine implementation does not support renegotiation yet, we throw aSSLExceptionto make it clear to callers that is the case. This matches behavior of some other providers that do not support renegotiation.closedwhen we receive fatal alerts on the client or server sides. This fix was made after running the SunJSSEEngineCloseOnAlerttest against wolfJSSE.This PR includes one change to the session resumption cache:
WOLFSSL_SESSIONis resumable. This wraps the native APIwolfSSL_SESSION_is_resumable()inWolfSSLSession.sessionIsResumable()and uses that to check. This will ensure we don't try to store or resume a session that native wolfSSL does not consider resumable.