JSSE: add LDAPS endpoint identification to X509ExtendedTrustManager #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Endpoint Identification for hostname verification to wolfJSSE's X509ExtendedTrustManager implementation.
Previously we had only supported HTTPS endpoint identification, but with this now support both HTTPS (RFC 2818) and LDAPS (RFC 2830).
Calling code needs to sent the endpoint identification to LDAPS on their SSLParameters being used:
PR also includes ant tests for LDAPS hostname verification.
Depends on native wolfSSL support for left-most wildcard matching, which was merged in as of wolfSSL/wolfssl#7966.