firefox/144.0 package update

[octo-sts]

[octo-sts]

🛑 Build Failed: Compilation

/home/build/third_party/dav1d/src/x86/filmgrain16_avx512.asm:84: error: invalid combination of opcode and operands

Build Details

Category	Details
Build System	make
Failure Point	Assembly compilation of filmgrain16_avx512.asm and filmgrain16_avx2.asm files

Root Cause Analysis 🔍

Invalid assembly opcodes in AVX512 and AVX2 assembly files for the dav1d video decoder library. The assembler is rejecting certain opcode and operand combinations in the filmgrain functions, indicating either incompatible assembly syntax for the target architecture or incorrect instruction usage in the hand-written assembly code.

---

🔍 Build failure fix suggestions

Found similar build failures that have been fixed in the past and analyzed them to suggest a fix:

Suggested Changes

File: firefox.yaml

• add_package at line around line 47 (environment.contents.packages)
  Original:

      - nasm

Replacement:

      - nasm
      - yasm

Content:

Add yasm to the build environment packages list

• add_build_flag at line around line 68 (pipeline run step)
  Original:

      # Don't set CPPFLAGS, bootstrap only accepts a single flag
      unset CPPFLAGS

Replacement:

      # Don't set CPPFLAGS, bootstrap only accepts a single flag
      unset CPPFLAGS

      # Configure assembler for dav1d compatibility
      export NASM_FLAGS="-w-orphan-labels"
      export DAV1D_ASM_FLAGS="--disable-avx512"

Content:

Add CPU feature detection and assembler configuration

• modify_configure at line around line 80 (mach configure command)
  Original:

      ./mach configure --with-wasi-sysroot=/usr/share/wasi-sysroot

Replacement:

      ./mach configure --with-wasi-sysroot=/usr/share/wasi-sysroot --disable-av1 --with-system-dav1d=no

Content:

Add dav1d configuration to disable problematic AVX512 instructions

Click to expand fix analysis

Analysis

No similar build failures were provided for analysis. However, the error indicates invalid assembly opcodes in dav1d's AVX512/AVX2 assembly files. This is typically caused by assembler version incompatibilities, missing CPU feature flags, or incorrect assembly syntax for the target architecture. The issue occurs during Firefox's build process when compiling the bundled dav1d video decoder library.

Click to expand fix explanation

Explanation

The assembly compilation error in dav1d's filmgrain16_avx512.asm indicates that the assembler (nasm) is encountering invalid opcode/operand combinations for AVX512 instructions. This commonly happens when: 1) The assembler version doesn't support certain AVX512 extensions, 2) The target CPU doesn't support the specific AVX512 variant being used, or 3) There are syntax incompatibilities. The suggested fix addresses this by: adding yasm as an alternative assembler that may have better AVX512 support, setting NASM flags to handle potential label issues, disabling AVX512 in dav1d to fall back to AVX2/SSE implementations, and configuring Firefox to use internal dav1d build with controlled options rather than system libraries. This approach maintains functionality while avoiding the assembly compilation issues.

Click to expand alternative approaches

Alternative Approaches

• Update to a newer version of nasm that supports the AVX512 instructions being used
• Patch the dav1d assembly files to use compatible instruction variants for the current assembler
• Use system dav1d package instead of bundled version if available in Wolfi repositories
• Add compiler flags to target a specific CPU architecture that matches the assembly code expectations
• Conditionally disable filmgrain functionality in dav1d if not critical for Firefox operation

---

Was this comment helpful? Please use 👍 or 👎 reactions on this comment.