Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/apk: don't log requests #1393

Merged
merged 2 commits into from
Jan 8, 2025
Merged

pkg/apk: don't log requests #1393

merged 2 commits into from
Jan 8, 2025

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Jan 8, 2025

hashi's retryablehttp debug-logs every request, which is noisy and incompatible with log/slog (hashicorp/go-retryablehttp#211), so let's just make it totally quiet until we can make it debug-quiet.

Before

go test ./pkg/apk -v -run=Test_getApkPackages
=== RUN   Test_getApkPackages
2025/01/08 09:20:59 [DEBUG] GET http://127.0.0.1:58527/APKINDEX.tar.gz
2025/01/08 09:20:59 found 2 latest apk index package versions
--- PASS: Test_getApkPackages (0.00s)
PASS
ok      github.com/wolfi-dev/wolfictl/pkg/apk   0.306s

After

go test ./pkg/apk -v -run=Test_getApkPackages
=== RUN   Test_getApkPackages
2025/01/08 09:20:52 found 2 latest apk index package versions
--- PASS: Test_getApkPackages (0.00s)
PASS
ok      github.com/wolfi-dev/wolfictl/pkg/apk   0.327s

Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Copy link
Member

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thank you thank you — this has been annoying <3

@luhring luhring enabled auto-merge January 8, 2025 15:22
@luhring luhring merged commit b68e98d into wolfi-dev:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants