Fix warning: Cast thread id to uint32_t #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix MSVC Warning C4244: 'argument': conversion from 'uint64_t' to 'uint32_t', possible loss of data We only store 32 bit thread ids in ThreadNameData. Trying to follow existing style instead of static_cast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MSVC Warning C4244: 'argument': conversion from 'uint64_t' to 'uint32_t', possible loss of data
Since public\client\TracyProfiler.cpp is included in client code, it'd be nice to clean up this warning. It's the only warning I saw compiling v0.10 with VS2022.
We only store 32 bit thread ids in ThreadNameData. Looks like Windows threadids (
DWORD) and Linux process ids (pid_t) are 32 bits so it seems fine.Trying to follow existing style instead of static_cast.