-
-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use int32_t
type instead of int
#961
Conversation
Why does this matter? I don't think there is an expectation for int to be 32 bit in the cases you have changed (I have not looked thoroughly though). Also, why have you added explicit conversion between bool and int? |
I wrote bindings for Fortran. It is useful to have consistent types both in Fortran and C sides (except unsigned integers, Fortran does not have them). So for
Most of changes were related to
Just for explicit conversion between types. Always nice to have :) |
Ooops. I forgot about Python API. |
This seems to me like a defect in the compiler? I would expect the compiler to follow the 64 bit data model of the platform it targets, instead of randomly selecting a model that will produce binaries that do not match the ABI. |
It is a feature. It switches between LP64/ILP64 models for both, Fortran and C, languages and it does not care about linking with binaries produced by other compilers. |
This patch updates C API (and others too) for using
int32_t
type. After the patch, tracy should be more portable for cases ifint
type has a size different from 4 bytes.Fixes #953