Support different authentication methods #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Split ClientConfig and ManagedClientConfig (revert to Comcast) 2. Rename ConsumerConfig to ManagedConsumerConfig 3. Rename ProducerConfig to ManagedProducerConfig 4. Rename NewPartitionManagedConsumer() to NewManagedPartitionConsumer() (according to ManagedPartitionConsumer type name and NewManagedPartitionProducer()) 5. Reorder code: type constructor, type definition, type methods 6. Unpublish fields that are not used by other pulsar-go-client packages (revert to Comcast) 7. Fixed build error in managed_consumer.go (Go 1.13 faults at https://github.com/wolfstudy/pulsar-client-go/blob/6c1405cf4104fe07f70bbd2a6d26197dd2d8e21e/core/manage/managed_consumer.go#L216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I've tried to connect to Pulsar with token authentication, but client does not support this auth mode.
Modifications
Verifying this change
This change is already covered by existing tests.