Added Installation section which includes basic instructions on how t…#118
Open
Arsivnet wants to merge 2 commits intowolkykim:mainfrom
Open
Added Installation section which includes basic instructions on how t…#118Arsivnet wants to merge 2 commits intowolkykim:mainfrom
Arsivnet wants to merge 2 commits intowolkykim:mainfrom
Conversation
…o install and also specifies that it needs at least GNU99 but also compiles at GNU23
wolkykim
reviewed
Dec 30, 2025
README.md
Outdated
| sudo make install | ||
| ``` | ||
|
|
||
| Alternatively, you can use Cmake. qLibc requires at least GNU99 and confirmed to be compiling in GNU23 |
Owner
There was a problem hiding this comment.
I expect all the Linux/Linux-like users to use autotools and CMake for Windows.
Do you think we should include Windows installation instructions instead?
Author
There was a problem hiding this comment.
I think both would be good. There's always new people coming to Linux these days. For windows we could add steps both for visual studio and VScode, also maybe a cmd/powershell option.
wolkykim
reviewed
Jan 8, 2026
Comment on lines
26
to
33
|
|
||
| ```bash | ||
| mkdir build | ||
| cd build | ||
| cmake .. | ||
| sudo make install | ||
| ``` | ||
|
|
Owner
There was a problem hiding this comment.
Let's take this part out for now. Not sure if this should be the officially recommended way.
Author
There was a problem hiding this comment.
Just removed that section and pushed
Removed Cmake alternative build method from the installation section as it's not certain if it should be an official recommended way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. I was checking the repo and decided to try out. I added an "installation" part on the readme that also specifies the standard.
The repo compiles successfully both for GNU99 and GNU23. I used both cmake and AutoTools. I modified CmakeLists.txt like so in line 32:
SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu23")Same for GNU99.
When i tried strictly for C99 like this:
SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=c99 -pedantic")It worked with AutoTools.
./configure make sudo make installBut C99 did NOT work when i tried cmake.
mkdir build cmake .. makeGave an error like this:
/home/user/qlibc/src/internal/qinternal.h:80:52: error: ‘PTHREAD_MUTEX_RECURSIVE’ undeclared (first use in this function); did you mean ‘PTHREAD_MUTEX_RECURSIVE_NP’? 80 | pthread_mutexattr_settype(&_mutexattr, PTHREAD_MUTEX_RECURSIVE); \fixes #115