Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TaskViewModal improvements #1318

Open
wants to merge 17 commits into
base: staging
Choose a base branch
from
Open

TaskViewModal improvements #1318

wants to merge 17 commits into from

Conversation

valyefimov
Copy link
Contributor

@valyefimov valyefimov commented Dec 8, 2022 •
edited
Loading

📘 Description

List of improvements:

  • allow open multiple modals
  • display task/milestone immediately
  • handle browser's back button
  • improve performance
  • added skeleton

🎥 Screenshot or Video

https://www.loom.com/share/bd15207f447f4dc4855fd56fa58080e5

🍰 Checklist:

@valyefimov valyefimov added the do not merge don't merge label Dec 8, 2022
@valyefimov valyefimov self-assigned this Dec 8, 2022
@vercel
Copy link

vercel bot commented Dec 8, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
wonderverse-web ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 4:44PM (UTC)
wondrous-app ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 4:44PM (UTC)

@valyefimov valyefimov changed the base branch from master to staging December 8, 2022 23:30
@valyefimov
Merge remote-tracking branch 'origin/staging' into fix/multiple-open-…
52dfd71 
…modals

# Conflicts:
#	wondrous-app/components/Common/Task/TaskCard.tsx
#	wondrous-app/components/Common/TaskViewModal/TaskViewModal.tsx
#	wondrous-app/components/Common/TaskViewModal/TaskViewModalWatcher.tsx
@valyefimov valyefimov marked this pull request as ready for review December 14, 2022 16:12
@valyefimov
Merge remote-tracking branch 'origin/staging' into fix/multiple-open-…
87f2791 
…modals

# Conflicts:
#	wondrous-app/components/BountySection/BountySection.tsx
#	wondrous-app/components/organization/project.tsx
#	wondrous-app/pages/pod/[podId]/boards.lazy.tsx
#	wondrous-app/utils/contexts.ts
@valyefimov valyefimov changed the title fix: allow open multiple modals TaskViewModal improvements Dec 16, 2022
@valyefimov
Merge remote-tracking branch 'origin/staging' into fix/multiple-open-…
88d5a41 
…modals

# Conflicts:
#	wondrous-app/components/BountySection/BountySection.tsx
#	wondrous-app/components/organization/project.tsx
#	wondrous-app/pages/pod/[podId]/boards.lazy.tsx
#	wondrous-app/utils/contexts.ts
@andywong418
Copy link
Contributor

@VEfimov looks like there is a conflict here?

@andywong418
Copy link
Contributor

Would you also be able to demo this works for subtask view (multiple sub task views) - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juniusfree juniusfree Awaiting requested review from juniusfree

@terryli0095 terryli0095 Awaiting requested review from terryli0095

@Lamperoyge Lamperoyge Awaiting requested review from Lamperoyge

@andywong418 andywong418 Awaiting requested review from andywong418

At least 1 approving review is required to merge this pull request.

Assignees

@valyefimov valyefimov

Labels
Ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valyefimov @andywong418