Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR unit tests matrix #997

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Update PR unit tests matrix #997

merged 2 commits into from
Sep 25, 2023

Conversation

lsinger
Copy link
Contributor

@lsinger lsinger commented Sep 25, 2023

Action Scheduler's unit test matrix tries to run tests with PHP 5.6 and WordPress latest. As of 6.3, WordPress supports only PHP versions 7+, so the "PHP 5.6 / WordPress latest" tests have been failing very quickly.

This PR excludes that combination from the test matrix (and also updates the .gitignore file by picking the most relevant bits from WooCommerce's).

Also see #996 for additional tasks around this issue.

@lsinger lsinger requested a review from a team September 25, 2023 09:49
@lsinger lsinger self-assigned this Sep 25, 2023
@lsinger lsinger requested review from barryhughes and removed request for a team September 25, 2023 09:49
Copy link
Member

@barryhughes barryhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@barryhughes barryhughes merged commit 82b051b into trunk Sep 25, 2023
36 checks passed
@barryhughes barryhughes deleted the update/pr-unit-tests-matrix branch September 25, 2023 19:39
@barryhughes barryhughes added this to the 3.6.4 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants