Skip to content

Conversation

masteradhoc
Copy link

All Submissions:

Changes proposed in this Pull Request:

With the new get and set methods of brands getting added to Woo i wanted to test with a good amount of testdata.
But saw that the feature wasnt implemented into Smooth Generator (#163).
I went ahead and added that feature like this:

  • Implemented a new faker collection from the same provider so we get proper brand names (see here)
  • generate brands in case not enough are set
  • generate products and assign 1(one) brand to the product

Closes #163 .

How to test the changes in this Pull Request:

  1. implement PR
  2. generate x products
  3. check if brands get generated (/wp-admin/edit-tags.php?taxonomy=product_brand&post_type=product)
  4. check if brands are assigned to the newly created products

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Create brands and assign to generated products

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Assign brands to generated products
1 participant