Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2025

Bumps androidx-hilt from 1.2.0 to 1.3.0.
Updates androidx.hilt:hilt-common from 1.2.0 to 1.3.0

Updates androidx.hilt:hilt-compiler from 1.2.0 to 1.3.0

Updates androidx.hilt:hilt-navigation-compose from 1.2.0 to 1.3.0

Updates androidx.hilt:hilt-navigation-fragment from 1.2.0 to 1.3.0

Updates androidx.hilt:hilt-work from 1.2.0 to 1.3.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `androidx-hilt` from 1.2.0 to 1.3.0.

Updates `androidx.hilt:hilt-common` from 1.2.0 to 1.3.0

Updates `androidx.hilt:hilt-compiler` from 1.2.0 to 1.3.0

Updates `androidx.hilt:hilt-navigation-compose` from 1.2.0 to 1.3.0

Updates `androidx.hilt:hilt-navigation-fragment` from 1.2.0 to 1.3.0

Updates `androidx.hilt:hilt-work` from 1.2.0 to 1.3.0

---
updated-dependencies:
- dependency-name: androidx.hilt:hilt-common
  dependency-version: 1.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.hilt:hilt-compiler
  dependency-version: 1.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.hilt:hilt-navigation-compose
  dependency-version: 1.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.hilt:hilt-navigation-fragment
  dependency-version: 1.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.hilt:hilt-work
  dependency-version: 1.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the bot: dependencies update PRs that update a dependency file, used by Dependabot. label Sep 16, 2025
@dependabot dependabot bot requested a review from a team as a code owner September 16, 2025 18:02
@dependabot dependabot bot requested review from hichamboushaba and removed request for a team September 16, 2025 18:02
@dependabot dependabot bot added the bot: dependencies update PRs that update a dependency file, used by Dependabot. label Sep 16, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 16, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.4. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 16, 2025

Project dependencies changes

list
+ New Dependencies
androidx.hilt:hilt-lifecycle-viewmodel:1.3.0
androidx.hilt:hilt-lifecycle-viewmodel-compose:1.3.0

- Removed Dependencies
androidx.hilt:hilt-navigation:1.2.0

! Upgraded Dependencies
androidx.hilt:hilt-common:1.3.0, (changed from 1.2.0)
androidx.hilt:hilt-navigation-compose:1.3.0, (changed from 1.2.0)
androidx.hilt:hilt-navigation-fragment:1.3.0, (changed from 1.2.0)
androidx.hilt:hilt-work:1.3.0, (changed from 1.2.0)
tree
-+--- androidx.hilt:hilt-navigation-fragment:1.2.0
-|    +--- androidx.hilt:hilt-navigation:1.2.0
-|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.9.1 (*)
-|    |    +--- androidx.navigation:navigation-runtime:2.5.1 -> 2.9.5 (*)
-|    |    +--- com.google.dagger:hilt-android:2.49 -> 2.57.1 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.2.0 (*)
-|    +--- androidx.navigation:navigation-fragment-ktx:2.5.1 -> 2.9.5
-|    |    +--- androidx.navigation:navigation-fragment:2.9.5 (*)
-|    |    +--- androidx.navigation:navigation-common:2.9.5 (c)
-|    |    +--- androidx.navigation:navigation-compose:2.9.5 (c)
-|    |    +--- androidx.navigation:navigation-fragment:2.9.5 (c)
-|    |    +--- androidx.navigation:navigation-runtime:2.9.5 (c)
-|    |    \--- androidx.navigation:navigation-ui:2.9.5 (c)
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.2.0 (*)
++--- androidx.hilt:hilt-navigation-fragment:1.3.0
+|    +--- androidx.hilt:hilt-lifecycle-viewmodel:1.3.0
+|    |    +--- com.google.dagger:hilt-android:2.54 -> 2.57.1 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
+|    +--- androidx.navigation:navigation-fragment-ktx:2.9.0 -> 2.9.5
+|    |    +--- androidx.navigation:navigation-fragment:2.9.5 (*)
+|    |    +--- androidx.navigation:navigation-common:2.9.5 (c)
+|    |    +--- androidx.navigation:navigation-compose:2.9.5 (c)
+|    |    +--- androidx.navigation:navigation-fragment:2.9.5 (c)
+|    |    +--- androidx.navigation:navigation-runtime:2.9.5 (c)
+|    |    \--- androidx.navigation:navigation-ui:2.9.5 (c)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
-+--- androidx.hilt:hilt-common:1.2.0
-|    \--- com.google.dagger:hilt-core:2.49 -> 2.57.1 (*)
++--- androidx.hilt:hilt-common:1.3.0
+|    \--- com.google.dagger:hilt-core:2.54 -> 2.57.1 (*)
-+--- androidx.hilt:hilt-work:1.2.0
-|    +--- androidx.annotation:annotation:1.1.0 -> 1.9.1 (*)
-|    +--- androidx.hilt:hilt-common:1.2.0 (*)
-|    +--- androidx.work:work-runtime:2.3.4 -> 2.10.5 (*)
-|    \--- com.google.dagger:hilt-android:2.49 -> 2.57.1 (*)
++--- androidx.hilt:hilt-work:1.3.0
+|    +--- androidx.annotation:annotation:1.8.1 -> 1.9.1 (*)
+|    +--- androidx.hilt:hilt-common:1.3.0 (*)
+|    +--- androidx.work:work-runtime:2.3.4 -> 2.10.5 (*)
+|    +--- com.google.dagger:hilt-android:2.54 -> 2.57.1 (*)
+|    \--- org.jspecify:jspecify:1.0.0
-\--- androidx.hilt:hilt-navigation-compose:1.2.0
-     +--- androidx.compose.runtime:runtime:1.0.1 -> 1.9.0 (*)
-     +--- androidx.compose.ui:ui:1.0.1 -> 1.9.0 (*)
-     +--- androidx.hilt:hilt-navigation:1.2.0 (*)
-     +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.1 -> 2.9.3 (*)
-     +--- androidx.navigation:navigation-compose:2.5.1 -> 2.9.5 (*)
-     \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.2.0 (*)
+\--- androidx.hilt:hilt-navigation-compose:1.3.0
+     +--- androidx.compose.runtime:runtime:1.8.2 -> 1.9.0 (*)
+     +--- androidx.compose.ui:ui:1.8.2 -> 1.9.0 (*)
+     +--- androidx.hilt:hilt-lifecycle-viewmodel-compose:1.3.0
+     |    +--- androidx.compose.runtime:runtime:1.8.2 -> 1.9.0 (*)
+     |    +--- androidx.compose.ui:ui:1.8.2 -> 1.9.0 (*)
+     |    +--- androidx.hilt:hilt-lifecycle-viewmodel:1.3.0 (*)
+     |    +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.9.1 -> 2.9.3 (*)
+     |    +--- com.google.dagger:hilt-android:2.54 -> 2.57.1 (*)
+     |    +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
+     |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
+     +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.9.1 -> 2.9.3 (*)
+     +--- androidx.navigation:navigation-compose:2.9.0 -> 2.9.5 (*)
+     +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
+     \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)

@JorgeMucientes
Copy link
Contributor

Hey @hichamboushaba, is there any blocker preventing this update from being addressed?

@hichamboushaba
Copy link
Member

@JorgeMucientes I'll check it out this week, I was just busy with CIAB tasks, and given the build was failing for the update, I didn't prioritize working on it.

@hichamboushaba hichamboushaba self-assigned this Oct 2, 2025
@hichamboushaba hichamboushaba added this to the 23.4 milestone Oct 2, 2025
Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after updating the code with the new APIs.

I tested with the steps of #9956 and confirmed the hiltNavGraphViewModels bug is fixed.

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit9c7a659
Direct Downloadwoocommerce-wear-prototype-build-pr14624-9c7a659.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit9c7a659
Direct Downloadwoocommerce-prototype-build-pr14624-9c7a659.apk

@hichamboushaba hichamboushaba merged commit 845eb44 into trunk Oct 2, 2025
16 checks passed
@hichamboushaba hichamboushaba deleted the dependabot/gradle/androidx-hilt-1.3.0 branch October 2, 2025 20:04
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.37%. Comparing base (f50fe57) to head (9c7a659).
⚠️ Report is 5 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #14624   +/-   ##
=========================================
  Coverage     38.37%   38.37%           
- Complexity     9823     9824    +1     
=========================================
  Files          2093     2093           
  Lines        116745   116745           
  Branches      15622    15622           
=========================================
+ Hits          44803    44806    +3     
+ Misses        67782    67780    -2     
+ Partials       4160     4159    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: dependencies update PRs that update a dependency file, used by Dependabot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants