[POS][Local Catalog] Fix Variation.attributes deserializing #14643

samiuelson · 2025-09-22T11:13:46Z

Description

This PR fixes how the Variation attributtes are stored and read in POS. Previously the variation names were not displayed properly.

Steps to reproduce

Testing information

Go to POS
Tap on the variable product
Verify variation names are correctly displayed

The tests that have been performed

Above

Images/gif

Before	After

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

wpmobilebot · 2025-09-22T11:19:36Z

Project dependencies changes

list

! Upgraded Dependencies
androidx.navigation:navigation-common:2.9.4, (changed from 2.9.3)
androidx.navigation:navigation-common-android:2.9.4, (changed from 2.9.3)
androidx.navigation:navigation-compose:2.9.4, (changed from 2.9.3)
androidx.navigation:navigation-compose-android:2.9.4, (changed from 2.9.3)
androidx.navigation:navigation-fragment:2.9.4, (changed from 2.9.3)
androidx.navigation:navigation-fragment-ktx:2.9.4, (changed from 2.9.3)
androidx.navigation:navigation-runtime:2.9.4, (changed from 2.9.3)
androidx.navigation:navigation-runtime-android:2.9.4, (changed from 2.9.3)
androidx.navigation:navigation-ui:2.9.4, (changed from 2.9.3)
com.google.android.gms:play-services-auth:21.4.0, (changed from 21.3.0)

tree

-+--- com.google.android.gms:play-services-auth:21.3.0
-|    +--- androidx.fragment:fragment:1.5.7 -> 1.8.7 (*)
-|    +--- androidx.loader:loader:1.1.0 (*)
-|    +--- com.google.android.gms:play-services-auth-api-phone:18.0.2
-|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.5.0 (*)
-|    |    +--- com.google.android.gms:play-services-basement:18.0.2 -> 18.5.0 (*)
-|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.2.0 (*)
-|    +--- com.google.android.gms:play-services-auth-base:18.0.10
-|    |    +--- androidx.collection:collection:1.0.0 -> 1.5.0 (*)
-|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.5.0 (*)
-|    |    +--- com.google.android.gms:play-services-basement:18.2.0 -> 18.5.0 (*)
-|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.2.0 (*)
-|    +--- com.google.android.gms:play-services-base:18.5.0 (*)
-|    +--- com.google.android.gms:play-services-basement:18.4.0 -> 18.5.0 (*)
-|    +--- com.google.android.gms:play-services-fido:20.0.1 -> 21.0.0
-|    |    +--- com.google.android.gms:play-services-base:18.3.0 -> 18.5.0 (*)
-|    |    +--- com.google.android.gms:play-services-basement:18.3.0 -> 18.5.0 (*)
-|    |    +--- com.google.android.gms:play-services-tasks:18.1.0 -> 18.2.0 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.9.0 -> 1.9.24 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.10.2 (*)
-|    \--- com.google.android.gms:play-services-tasks:18.2.0 (*)
++--- com.google.android.gms:play-services-auth:21.4.0
+|    +--- androidx.fragment:fragment:1.5.7 -> 1.8.7 (*)
+|    +--- androidx.loader:loader:1.1.0 (*)
+|    +--- com.google.android.gms:play-services-auth-api-phone:18.0.2
+|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.5.0 (*)
+|    |    +--- com.google.android.gms:play-services-basement:18.0.2 -> 18.5.0 (*)
+|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.2.0 (*)
+|    +--- com.google.android.gms:play-services-auth-base:18.0.10
+|    |    +--- androidx.collection:collection:1.0.0 -> 1.5.0 (*)
+|    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.5.0 (*)
+|    |    +--- com.google.android.gms:play-services-basement:18.2.0 -> 18.5.0 (*)
+|    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.2.0 (*)
+|    +--- com.google.android.gms:play-services-base:18.5.0 (*)
+|    +--- com.google.android.gms:play-services-basement:18.5.0 (*)
+|    +--- com.google.android.gms:play-services-fido:20.0.1 -> 21.0.0
+|    |    +--- com.google.android.gms:play-services-base:18.3.0 -> 18.5.0 (*)
+|    |    +--- com.google.android.gms:play-services-basement:18.3.0 -> 18.5.0 (*)
+|    |    +--- com.google.android.gms:play-services-tasks:18.1.0 -> 18.2.0 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.9.0 -> 1.9.24 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.10.2 (*)
+|    \--- com.google.android.gms:play-services-tasks:18.2.0 (*)
-+--- androidx.navigation:navigation-common:2.9.3
-|    \--- androidx.navigation:navigation-common-android:2.9.3
-|         +--- androidx.annotation:annotation:1.8.1 -> 1.9.1 (*)
-|         +--- androidx.collection:collection:1.4.2 -> 1.5.0 (*)
-|         +--- androidx.core:core-ktx:1.1.0 -> 1.16.0 (*)
-|         +--- androidx.lifecycle:lifecycle-common:2.9.0 -> 2.9.3 (*)
-|         +--- androidx.lifecycle:lifecycle-runtime:2.9.0 -> 2.9.3 (*)
-|         +--- androidx.lifecycle:lifecycle-viewmodel:2.9.0 -> 2.9.3 (*)
-|         +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.9.0 -> 2.9.3 (*)
-|         +--- androidx.profileinstaller:profileinstaller:1.4.0 (*)
-|         +--- androidx.savedstate:savedstate:1.3.0 -> 1.3.1 (*)
-|         +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
-|         +--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3 (*)
-|         +--- androidx.navigation:navigation-compose:2.9.3 (c)
-|         +--- androidx.navigation:navigation-fragment:2.9.3 (c)
-|         +--- androidx.navigation:navigation-fragment-ktx:2.9.3 (c)
-|         +--- androidx.navigation:navigation-runtime:2.9.3 (c)
-|         +--- androidx.navigation:navigation-ui:2.9.3 (c)
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
++--- androidx.navigation:navigation-common:2.9.4
+|    \--- androidx.navigation:navigation-common-android:2.9.4
+|         +--- androidx.annotation:annotation:1.8.1 -> 1.9.1 (*)
+|         +--- androidx.collection:collection:1.4.2 -> 1.5.0 (*)
+|         +--- androidx.core:core-ktx:1.1.0 -> 1.16.0 (*)
+|         +--- androidx.lifecycle:lifecycle-common:2.9.0 -> 2.9.3 (*)
+|         +--- androidx.lifecycle:lifecycle-runtime:2.9.0 -> 2.9.3 (*)
+|         +--- androidx.lifecycle:lifecycle-viewmodel:2.9.0 -> 2.9.3 (*)
+|         +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.9.0 -> 2.9.3 (*)
+|         +--- androidx.profileinstaller:profileinstaller:1.4.0 (*)
+|         +--- androidx.savedstate:savedstate:1.3.0 -> 1.3.1 (*)
+|         +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
+|         +--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3 (*)
+|         +--- androidx.navigation:navigation-compose:2.9.4 (c)
+|         +--- androidx.navigation:navigation-fragment:2.9.4 (c)
+|         +--- androidx.navigation:navigation-fragment-ktx:2.9.4 (c)
+|         +--- androidx.navigation:navigation-runtime:2.9.4 (c)
+|         +--- androidx.navigation:navigation-ui:2.9.4 (c)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
-+--- androidx.navigation:navigation-fragment:2.9.3
-|    +--- androidx.activity:activity:1.7.2 -> 1.8.2 (*)
-|    +--- androidx.core:core-ktx:1.8.0 -> 1.16.0 (*)
-|    +--- androidx.fragment:fragment-ktx:1.6.2 -> 1.8.7 (*)
-|    +--- androidx.lifecycle:lifecycle-common:2.6.2 -> 2.9.3 (*)
-|    +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 -> 2.9.3 (*)
-|    +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 -> 2.9.3 (*)
-|    +--- androidx.navigation:navigation-common:2.9.3 (*)
-|    +--- androidx.navigation:navigation-runtime:2.9.3
-|    |    \--- androidx.navigation:navigation-runtime-android:2.9.3
-|    |         +--- androidx.activity:activity-ktx:1.7.1 -> 1.8.2 (*)
-|    |         +--- androidx.annotation:annotation-experimental:1.4.1 (*)
-|    |         +--- androidx.collection:collection:1.4.2 -> 1.5.0 (*)
-|    |         +--- androidx.core:core-ktx:1.8.0 -> 1.16.0 (*)
-|    |         +--- androidx.lifecycle:lifecycle-common:2.8.7 -> 2.9.3 (*)
-|    |         +--- androidx.lifecycle:lifecycle-runtime:2.8.7 -> 2.9.3 (*)
-|    |         +--- androidx.lifecycle:lifecycle-runtime-ktx:2.8.7 -> 2.9.3 (*)
-|    |         +--- androidx.lifecycle:lifecycle-viewmodel:2.8.7 -> 2.9.3 (*)
-|    |         +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.8.7 -> 2.9.3 (*)
-|    |         +--- androidx.navigation:navigation-common:2.9.3 (*)
-|    |         +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
-|    |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.10.2 (*)
-|    |         +--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3 (*)
-|    |         +--- androidx.navigation:navigation-common:2.9.3 (c)
-|    |         +--- androidx.navigation:navigation-compose:2.9.3 (c)
-|    |         +--- androidx.navigation:navigation-fragment:2.9.3 (c)
-|    |         +--- androidx.navigation:navigation-fragment-ktx:2.9.3 (c)
-|    |         +--- androidx.navigation:navigation-ui:2.9.3 (c)
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
-|    +--- androidx.savedstate:savedstate:1.2.1 -> 1.3.1 (*)
-|    +--- androidx.slidingpanelayout:slidingpanelayout:1.2.0 (*)
-|    +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.10.2 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3 (*)
-|    +--- androidx.navigation:navigation-common:2.9.3 (c)
-|    +--- androidx.navigation:navigation-compose:2.9.3 (c)
-|    +--- androidx.navigation:navigation-runtime:2.9.3 (c)
-|    +--- androidx.navigation:navigation-ui:2.9.3 (c)
-|    +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
-|    \--- androidx.navigation:navigation-fragment-ktx:2.9.3 (c)
++--- androidx.navigation:navigation-fragment:2.9.4
+|    +--- androidx.activity:activity:1.7.2 -> 1.8.2 (*)
+|    +--- androidx.core:core-ktx:1.8.0 -> 1.16.0 (*)
+|    +--- androidx.fragment:fragment-ktx:1.6.2 -> 1.8.7 (*)
+|    +--- androidx.lifecycle:lifecycle-common:2.6.2 -> 2.9.3 (*)
+|    +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 -> 2.9.3 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 -> 2.9.3 (*)
+|    +--- androidx.navigation:navigation-common:2.9.4 (*)
+|    +--- androidx.navigation:navigation-runtime:2.9.4
+|    |    \--- androidx.navigation:navigation-runtime-android:2.9.4
+|    |         +--- androidx.activity:activity-ktx:1.7.1 -> 1.8.2 (*)
+|    |         +--- androidx.annotation:annotation-experimental:1.4.1 (*)
+|    |         +--- androidx.collection:collection:1.4.2 -> 1.5.0 (*)
+|    |         +--- androidx.core:core-ktx:1.8.0 -> 1.16.0 (*)
+|    |         +--- androidx.lifecycle:lifecycle-common:2.8.7 -> 2.9.3 (*)
+|    |         +--- androidx.lifecycle:lifecycle-runtime:2.8.7 -> 2.9.3 (*)
+|    |         +--- androidx.lifecycle:lifecycle-runtime-ktx:2.8.7 -> 2.9.3 (*)
+|    |         +--- androidx.lifecycle:lifecycle-viewmodel:2.8.7 -> 2.9.3 (*)
+|    |         +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.8.7 -> 2.9.3 (*)
+|    |         +--- androidx.navigation:navigation-common:2.9.4 (*)
+|    |         +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
+|    |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.10.2 (*)
+|    |         +--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3 (*)
+|    |         +--- androidx.navigation:navigation-common:2.9.4 (c)
+|    |         +--- androidx.navigation:navigation-compose:2.9.4 (c)
+|    |         +--- androidx.navigation:navigation-fragment:2.9.4 (c)
+|    |         +--- androidx.navigation:navigation-fragment-ktx:2.9.4 (c)
+|    |         +--- androidx.navigation:navigation-ui:2.9.4 (c)
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
+|    +--- androidx.savedstate:savedstate:1.2.1 -> 1.3.1 (*)
+|    +--- androidx.slidingpanelayout:slidingpanelayout:1.2.0 (*)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.10.2 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3 (*)
+|    +--- androidx.navigation:navigation-common:2.9.4 (c)
+|    +--- androidx.navigation:navigation-compose:2.9.4 (c)
+|    +--- androidx.navigation:navigation-runtime:2.9.4 (c)
+|    +--- androidx.navigation:navigation-ui:2.9.4 (c)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
+|    \--- androidx.navigation:navigation-fragment-ktx:2.9.4 (c)
-+--- androidx.navigation:navigation-runtime:2.9.3 (*)
++--- androidx.navigation:navigation-runtime:2.9.4 (*)
-+--- androidx.navigation:navigation-ui:2.9.3
-|    +--- androidx.appcompat:appcompat:1.2.0 -> 1.7.1 (*)
-|    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
-|    +--- androidx.core:core-ktx:1.2.0 -> 1.16.0 (*)
-|    +--- androidx.customview:customview:1.1.0 (*)
-|    +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
-|    +--- androidx.navigation:navigation-common:2.9.3 (*)
-|    +--- androidx.navigation:navigation-runtime:2.9.3 (*)
-|    +--- androidx.transition:transition:1.3.0 -> 1.6.0 (*)
-|    +--- com.google.android.material:material:1.4.0 -> 1.12.0 (*)
-|    +--- androidx.navigation:navigation-common:2.9.3 (c)
-|    +--- androidx.navigation:navigation-compose:2.9.3 (c)
-|    +--- androidx.navigation:navigation-fragment:2.9.3 (c)
-|    +--- androidx.navigation:navigation-runtime:2.9.3 (c)
-|    \--- androidx.navigation:navigation-fragment-ktx:2.9.3 (c)
++--- androidx.navigation:navigation-ui:2.9.4
+|    +--- androidx.appcompat:appcompat:1.2.0 -> 1.7.1 (*)
+|    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+|    +--- androidx.core:core-ktx:1.2.0 -> 1.16.0 (*)
+|    +--- androidx.customview:customview:1.1.0 (*)
+|    +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
+|    +--- androidx.navigation:navigation-common:2.9.4 (*)
+|    +--- androidx.navigation:navigation-runtime:2.9.4 (*)
+|    +--- androidx.transition:transition:1.3.0 -> 1.6.0 (*)
+|    +--- com.google.android.material:material:1.4.0 -> 1.12.0 (*)
+|    +--- androidx.navigation:navigation-common:2.9.4 (c)
+|    +--- androidx.navigation:navigation-compose:2.9.4 (c)
+|    +--- androidx.navigation:navigation-fragment:2.9.4 (c)
+|    +--- androidx.navigation:navigation-runtime:2.9.4 (c)
+|    \--- androidx.navigation:navigation-fragment-ktx:2.9.4 (c)
 +--- project :libs:login
-|    +--- com.google.android.gms:play-services-auth:21.3.0 (*)
+|    +--- com.google.android.gms:play-services-auth:21.4.0 (*)
 |    \--- androidx.credentials:credentials-play-services-auth:1.5.0
-|         \--- com.google.android.gms:play-services-auth:21.1.1 -> 21.3.0 (*)
+|         \--- com.google.android.gms:play-services-auth:21.1.1 -> 21.4.0 (*)
 +--- com.automattic:about:1.7.0
-|    \--- androidx.navigation:navigation-compose:2.7.7 -> 2.9.3
-|         \--- androidx.navigation:navigation-compose-android:2.9.3
-|              +--- androidx.activity:activity:1.8.0 -> 1.8.2 (*)
-|              +--- androidx.activity:activity-compose:1.8.0 -> 1.8.2 (*)
-|              +--- androidx.annotation:annotation:1.8.0 -> 1.9.1 (*)
-|              +--- androidx.collection:collection:1.4.5 -> 1.5.0 (*)
-|              +--- androidx.compose.animation:animation:1.7.2 -> 1.9.0 (*)
-|              +--- androidx.compose.animation:animation-core:1.7.2 -> 1.9.0 (*)
-|              +--- androidx.compose.foundation:foundation-layout:1.7.2 -> 1.9.0 (*)
-|              +--- androidx.compose.runtime:runtime:1.7.2 -> 1.9.0 (*)
-|              +--- androidx.compose.runtime:runtime-saveable:1.7.2 -> 1.9.0 (*)
-|              +--- androidx.compose.ui:ui:1.7.2 -> 1.9.0 (*)
-|              +--- androidx.lifecycle:lifecycle-common:2.9.0 -> 2.9.3 (*)
-|              +--- androidx.lifecycle:lifecycle-runtime-compose:2.9.0 -> 2.9.3 (*)
-|              +--- androidx.lifecycle:lifecycle-viewmodel:2.9.0 -> 2.9.3 (*)
-|              +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.8.2 -> 2.9.3
-|              |    \--- androidx.lifecycle:lifecycle-viewmodel-compose-android:2.9.3
-|              |         +--- androidx.annotation:annotation:1.9.1 (*)
-|              |         +--- androidx.compose.runtime:runtime:1.9.0 (*)
-|              |         +--- androidx.compose.ui:ui:1.9.0 (*)
-|              |         +--- androidx.lifecycle:lifecycle-common:2.9.3 (*)
-|              |         +--- androidx.lifecycle:lifecycle-viewmodel:2.9.3 (*)
-|              |         +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.9.3 (*)
-|              |         +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
-|              |         +--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3 (*)
-|              |         +--- androidx.lifecycle:lifecycle-common:2.9.3 (c)
-|              |         +--- androidx.lifecycle:lifecycle-common-java8:2.9.3 (c)
-|              |         +--- androidx.lifecycle:lifecycle-livedata:2.9.3 (c)
-|              |         +--- androidx.lifecycle:lifecycle-livedata-core:2.9.3 (c)
-|              |         +--- androidx.lifecycle:lifecycle-process:2.9.3 (c)
-|              |         +--- androidx.lifecycle:lifecycle-runtime:2.9.3 (c)
-|              |         +--- androidx.lifecycle:lifecycle-runtime-compose:2.9.3 (c)
-|              |         +--- androidx.lifecycle:lifecycle-runtime-ktx:2.9.3 (c)
-|              |         +--- androidx.lifecycle:lifecycle-service:2.9.3 (c)
-|              |         +--- androidx.lifecycle:lifecycle-viewmodel:2.9.3 (c)
-|              |         +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.9.3 (c)
-|              |         +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.9.3 (c)
-|              |         +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
-|              |         \--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.9.3 (c)
-|              +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.9.0 -> 2.9.3 (*)
-|              +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.9.0 -> 2.9.3 (*)
-|              +--- androidx.navigation:navigation-common:2.9.3 (*)
-|              +--- androidx.navigation:navigation-runtime:2.9.3 (*)
-|              +--- androidx.savedstate:savedstate:1.3.0 -> 1.3.1 (*)
-|              +--- androidx.savedstate:savedstate-compose:1.3.0 -> 1.3.1 (*)
-|              +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
-|              +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.10.2 (*)
-|              +--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3 (*)
-|              +--- androidx.navigation:navigation-common:2.9.3 (c)
-|              +--- androidx.navigation:navigation-fragment:2.9.3 (c)
-|              +--- androidx.navigation:navigation-fragment-ktx:2.9.3 (c)
-|              +--- androidx.navigation:navigation-runtime:2.9.3 (c)
-|              +--- androidx.navigation:navigation-ui:2.9.3 (c)
-|              \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
+|    \--- androidx.navigation:navigation-compose:2.7.7 -> 2.9.4
+|         \--- androidx.navigation:navigation-compose-android:2.9.4
+|              +--- androidx.activity:activity:1.8.0 -> 1.8.2 (*)
+|              +--- androidx.activity:activity-compose:1.8.0 -> 1.8.2 (*)
+|              +--- androidx.annotation:annotation:1.8.0 -> 1.9.1 (*)
+|              +--- androidx.collection:collection:1.4.5 -> 1.5.0 (*)
+|              +--- androidx.compose.animation:animation:1.7.2 -> 1.9.0 (*)
+|              +--- androidx.compose.animation:animation-core:1.7.2 -> 1.9.0 (*)
+|              +--- androidx.compose.foundation:foundation-layout:1.7.2 -> 1.9.0 (*)
+|              +--- androidx.compose.runtime:runtime:1.7.2 -> 1.9.0 (*)
+|              +--- androidx.compose.runtime:runtime-saveable:1.7.2 -> 1.9.0 (*)
+|              +--- androidx.compose.ui:ui:1.7.2 -> 1.9.0 (*)
+|              +--- androidx.lifecycle:lifecycle-common:2.9.0 -> 2.9.3 (*)
+|              +--- androidx.lifecycle:lifecycle-runtime-compose:2.9.0 -> 2.9.3 (*)
+|              +--- androidx.lifecycle:lifecycle-viewmodel:2.9.0 -> 2.9.3 (*)
+|              +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.8.2 -> 2.9.3
+|              |    \--- androidx.lifecycle:lifecycle-viewmodel-compose-android:2.9.3
+|              |         +--- androidx.annotation:annotation:1.9.1 (*)
+|              |         +--- androidx.compose.runtime:runtime:1.9.0 (*)
+|              |         +--- androidx.compose.ui:ui:1.9.0 (*)
+|              |         +--- androidx.lifecycle:lifecycle-common:2.9.3 (*)
+|              |         +--- androidx.lifecycle:lifecycle-viewmodel:2.9.3 (*)
+|              |         +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.9.3 (*)
+|              |         +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
+|              |         +--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3 (*)
+|              |         +--- androidx.lifecycle:lifecycle-common:2.9.3 (c)
+|              |         +--- androidx.lifecycle:lifecycle-common-java8:2.9.3 (c)
+|              |         +--- androidx.lifecycle:lifecycle-livedata:2.9.3 (c)
+|              |         +--- androidx.lifecycle:lifecycle-livedata-core:2.9.3 (c)
+|              |         +--- androidx.lifecycle:lifecycle-process:2.9.3 (c)
+|              |         +--- androidx.lifecycle:lifecycle-runtime:2.9.3 (c)
+|              |         +--- androidx.lifecycle:lifecycle-runtime-compose:2.9.3 (c)
+|              |         +--- androidx.lifecycle:lifecycle-runtime-ktx:2.9.3 (c)
+|              |         +--- androidx.lifecycle:lifecycle-service:2.9.3 (c)
+|              |         +--- androidx.lifecycle:lifecycle-viewmodel:2.9.3 (c)
+|              |         +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.9.3 (c)
+|              |         +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.9.3 (c)
+|              |         +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
+|              |         \--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.9.3 (c)
+|              +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.9.0 -> 2.9.3 (*)
+|              +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.9.0 -> 2.9.3 (*)
+|              +--- androidx.navigation:navigation-common:2.9.4 (*)
+|              +--- androidx.navigation:navigation-runtime:2.9.4 (*)
+|              +--- androidx.savedstate:savedstate:1.3.0 -> 1.3.1 (*)
+|              +--- androidx.savedstate:savedstate-compose:1.3.0 -> 1.3.1 (*)
+|              +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
+|              +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.10.2 (*)
+|              +--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3 (*)
+|              +--- androidx.navigation:navigation-common:2.9.4 (c)
+|              +--- androidx.navigation:navigation-fragment:2.9.4 (c)
+|              +--- androidx.navigation:navigation-fragment-ktx:2.9.4 (c)
+|              +--- androidx.navigation:navigation-runtime:2.9.4 (c)
+|              +--- androidx.navigation:navigation-ui:2.9.4 (c)
+|              \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
 +--- androidx.hilt:hilt-navigation-fragment:1.2.0
 |    +--- androidx.hilt:hilt-navigation:1.2.0
-|    |    \--- androidx.navigation:navigation-runtime:2.5.1 -> 2.9.3 (*)
+|    |    \--- androidx.navigation:navigation-runtime:2.5.1 -> 2.9.4 (*)
-|    \--- androidx.navigation:navigation-fragment-ktx:2.5.1 -> 2.9.3
-|         +--- androidx.navigation:navigation-fragment:2.9.3 (*)
-|         +--- androidx.navigation:navigation-common:2.9.3 (c)
-|         +--- androidx.navigation:navigation-compose:2.9.3 (c)
-|         +--- androidx.navigation:navigation-fragment:2.9.3 (c)
-|         +--- androidx.navigation:navigation-runtime:2.9.3 (c)
-|         \--- androidx.navigation:navigation-ui:2.9.3 (c)
+|    \--- androidx.navigation:navigation-fragment-ktx:2.5.1 -> 2.9.4
+|         +--- androidx.navigation:navigation-fragment:2.9.4 (*)
+|         +--- androidx.navigation:navigation-common:2.9.4 (c)
+|         +--- androidx.navigation:navigation-compose:2.9.4 (c)
+|         +--- androidx.navigation:navigation-fragment:2.9.4 (c)
+|         +--- androidx.navigation:navigation-runtime:2.9.4 (c)
+|         \--- androidx.navigation:navigation-ui:2.9.4 (c)
-+--- androidx.navigation:navigation-compose:2.9.3 (*)
++--- androidx.navigation:navigation-compose:2.9.4 (*)
 \--- androidx.hilt:hilt-navigation-compose:1.2.0
-     \--- androidx.navigation:navigation-compose:2.5.1 -> 2.9.3 (*)
+     \--- androidx.navigation:navigation-compose:2.5.1 -> 2.9.4 (*)

Build environment changes

list

! Upgraded Dependencies
androidx.navigation.safeargs.kotlin:androidx.navigation.safeargs.kotlin.gradle.plugin:2.9.4, (changed from 2.9.3)
androidx.navigation:navigation-safe-args-generator:2.9.4, (changed from 2.9.3)
androidx.navigation:navigation-safe-args-gradle-plugin:2.9.4, (changed from 2.9.3)

tree

-\--- androidx.navigation.safeargs.kotlin:androidx.navigation.safeargs.kotlin.gradle.plugin:2.9.3
-     \--- androidx.navigation:navigation-safe-args-gradle-plugin:2.9.3
-          +--- androidx.navigation:navigation-safe-args-generator:2.9.3
-          |    +--- androidx.annotation:annotation:1.9.1
-          |    |    \--- androidx.annotation:annotation-jvm:1.9.1
-          |    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.2.0 (*)
-          |    +--- com.squareup:javapoet:1.13.0
-          |    +--- com.squareup:kotlinpoet:2.0.0 -> 2.1.0 (*)
-          |    +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
-          |    +--- xmlpull:xmlpull:1.1.3.1
-          |    +--- xpp3:xpp3:1.1.4c
-          |    +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
-          |    \--- androidx.navigation:navigation-safe-args-gradle-plugin:2.9.3 (c)
-          +--- com.google.code.gson:gson:2.9.0 -> 2.11.0 (*)
-          +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
-          +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
-          \--- androidx.navigation:navigation-safe-args-generator:2.9.3 (c)
+\--- androidx.navigation.safeargs.kotlin:androidx.navigation.safeargs.kotlin.gradle.plugin:2.9.4
+     \--- androidx.navigation:navigation-safe-args-gradle-plugin:2.9.4
+          +--- androidx.navigation:navigation-safe-args-generator:2.9.4
+          |    +--- androidx.annotation:annotation:1.9.1
+          |    |    \--- androidx.annotation:annotation-jvm:1.9.1
+          |    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.2.0 (*)
+          |    +--- com.squareup:javapoet:1.13.0
+          |    +--- com.squareup:kotlinpoet:2.0.0 -> 2.1.0 (*)
+          |    +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
+          |    +--- xmlpull:xmlpull:1.1.3.1
+          |    +--- xpp3:xpp3:1.1.4c
+          |    +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
+          |    \--- androidx.navigation:navigation-safe-args-gradle-plugin:2.9.4 (c)
+          +--- com.google.code.gson:gson:2.9.0 -> 2.11.0 (*)
+          +--- org.jetbrains.kotlin:kotlin-stdlib -> 2.2.0 (*)
+          +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.2.0 (c)
+          \--- androidx.navigation:navigation-safe-args-generator:2.9.4 (c)

wpmobilebot · 2025-09-22T11:22:50Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`a9ce602`
	Direct Download	`woocommerce-wear-prototype-build-pr14643-a9ce602.apk`

wpmobilebot · 2025-09-22T11:49:26Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`a9ce602`
	Direct Download	`woocommerce-prototype-build-pr14643-a9ce602.apk`

codecov-commenter · 2025-09-22T17:57:22Z

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 38.42%. Comparing base (e86309e) to head (a9ce602).
⚠️ Report is 16 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...product/pos/WooPosProductResponseToEntityMapper.kt	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##              trunk   #14643   +/-   ##
=========================================
  Coverage     38.42%   38.42%           
- Complexity     9823     9824    +1     
=========================================
  Files          2090     2090           
  Lines        116550   116542    -8     
  Branches      15575    15576    +1     
=========================================
- Hits          44784    44782    -2     
+ Misses        67612    67606    -6     
  Partials       4154     4154

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

...c-plugin/src/main/kotlin/org/wordpress/android/fluxc/model/pos/WooPosVariationApiResponse.kt

kidinov · 2025-09-30T08:33:22Z

In WooPosVariationEntity there is val attributesJson: String = "",.

Should it be defaulted to "[]"?

kidinov · 2025-09-30T08:38:31Z

I guess this is due to the WIP of the feature, but just in case:

PTR doesn't work
After logging in, I open the POS -> no variations at all

09-30--10-37.mp4

kidinov · 2025-09-30T08:48:19Z

@samiuelson I actually could not reproduce the fix. After a clean install, firstly, I have no variations shown at all. Then after a few restarts, it still shows me "Any, Any" 🤔

09-30--10-40.mp4

kidinov

@samiuelson there is something I need to know to reproduce the fix. Please take a look into my comments

…ion-attributes-storing-and

samiuelson · 2025-10-01T12:10:37Z

@samiuelson there is something I need to know to reproduce the fix. Please take a look into my comments

Thanks for review @kidinov! The fix should work, but I think variations may not be syncing because incremental sync is constrained by the last sync timestamp. As a result, the existing variation attributes in the DB may be stale and not synced correctly. Could you please try clearing the last sync time stamp by calling (e.g. in the POS splash screen): WooPosSyncTimestampManager::clearAllSyncTimestamps function?

dangermattic · 2025-10-01T12:30:03Z

	1 Warning
⚠️	This PR is assigned to the milestone 23.4. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

samiuelson · 2025-10-01T12:38:15Z

WooPosVariationEntity

WooPosVariationMapper::parseAttributesJson handles empty string as well, but I updated the default value to "[]" for consistency and extra safety as well: 2f3229b 👍

kidinov

LGTM! I removed the data again, and it worked

samiuelson changed the base branch from woomob-1072-woo-poslocal-catalog-connect-product-list-to-pos-products to trunk September 22, 2025 11:16

samiuelson changed the base branch from trunk to woomob-1069-woo-poslocal-catalog-update-ptr-behavior-fetch-products-and September 22, 2025 11:16

samiuelson changed the base branch from woomob-1069-woo-poslocal-catalog-update-ptr-behavior-fetch-products-and to woomob-1072-woo-poslocal-catalog-connect-product-list-to-pos-products September 22, 2025 11:17

Fix variation attributes deserializing

cc6e7a9

samiuelson force-pushed the woomob-1370-woo-poslocal-catalog-fix-variation-attributes-storing-and branch from b5a51f6 to cc6e7a9 Compare September 22, 2025 11:30

samiuelson changed the base branch from woomob-1072-woo-poslocal-catalog-connect-product-list-to-pos-products to trunk September 22, 2025 11:31

Fix attributesJson mapping

2dd7350

samiuelson marked this pull request as ready for review September 24, 2025 13:00

samiuelson added this to the 23.4 milestone Sep 24, 2025

samiuelson added type: task An internally driven task. feature: point of sale POS project labels Sep 24, 2025

samiuelson requested a review from malinajirka September 24, 2025 13:01

samiuelson changed the title ~~[Woo POS][Local Catalog] Fix Variation.attributes deserializing~~ [POS][Local Catalog] Fix Variation.attributes deserializing Sep 24, 2025

samiuelson requested review from kidinov and removed request for malinajirka September 29, 2025 15:45

kidinov self-assigned this Sep 30, 2025

kidinov reviewed Sep 30, 2025

View reviewed changes

...c-plugin/src/main/kotlin/org/wordpress/android/fluxc/model/pos/WooPosVariationApiResponse.kt Outdated Show resolved Hide resolved

kidinov self-requested a review September 30, 2025 08:48

kidinov reviewed Sep 30, 2025

View reviewed changes

Merge branch 'trunk' into woomob-1370-woo-poslocal-catalog-fix-variat…

772e960

…ion-attributes-storing-and

samiuelson requested a review from kidinov October 1, 2025 12:11

Rename attributes property to attributesJson

d089eb2

Update default attributes string

2f3229b

Revert test clearAllSyncTimestamps() call

a9ce602

kidinov approved these changes Oct 1, 2025

View reviewed changes

kidinov merged commit 6086960 into trunk Oct 1, 2025
15 checks passed

kidinov deleted the woomob-1370-woo-poslocal-catalog-fix-variation-attributes-storing-and branch October 1, 2025 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[POS][Local Catalog] Fix Variation.attributes deserializing #14643

[POS][Local Catalog] Fix Variation.attributes deserializing #14643

Uh oh!

samiuelson commented Sep 22, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Sep 22, 2025

Uh oh!

wpmobilebot commented Sep 22, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Sep 22, 2025 •

edited

Loading

Uh oh!

codecov-commenter commented Sep 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

kidinov commented Sep 30, 2025

Uh oh!

kidinov commented Sep 30, 2025

Uh oh!

kidinov commented Sep 30, 2025

Uh oh!

kidinov left a comment

Uh oh!

samiuelson commented Oct 1, 2025 •

edited

Loading

Uh oh!

dangermattic commented Oct 1, 2025

Uh oh!

samiuelson commented Oct 1, 2025

Uh oh!

kidinov left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[POS][Local Catalog] Fix Variation.attributes deserializing #14643

[POS][Local Catalog] Fix Variation.attributes deserializing #14643

Uh oh!

Conversation

samiuelson commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

Uh oh!

wpmobilebot commented Sep 22, 2025

Project dependencies changes

Build environment changes

Uh oh!

wpmobilebot commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

kidinov commented Sep 30, 2025

Uh oh!

kidinov commented Sep 30, 2025

Uh oh!

kidinov commented Sep 30, 2025

Uh oh!

kidinov left a comment

Choose a reason for hiding this comment

Uh oh!

samiuelson commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangermattic commented Oct 1, 2025

Uh oh!

samiuelson commented Oct 1, 2025

Uh oh!

kidinov left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

samiuelson commented Sep 22, 2025 •

edited

Loading

wpmobilebot commented Sep 22, 2025 •

edited

Loading

wpmobilebot commented Sep 22, 2025 •

edited

Loading

codecov-commenter commented Sep 22, 2025 •

edited

Loading

samiuelson commented Oct 1, 2025 •

edited

Loading

kidinov left a comment •

edited

Loading